-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #78920
Rollup of 14 pull requests #78920
Commits on Oct 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 20e032e - Browse repository at this point
Copy the full SHA 20e032eView commit details
Commits on Oct 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 68d2cd5 - Browse repository at this point
Copy the full SHA 68d2cd5View commit details
Commits on Nov 7, 2020
-
Assert that a return place is not used for indexing during integration
The inliner integrates call destination place with callee return place by remapping the local and adding extra projections as necessary. If a call destination place contains any projections (which is already possible) and a return place is used in an indexing projection (most likely doesn't happen yet) the end result would be incorrect. Add an assertion to ensure that potential issue won't go unnoticed in the presence of more sophisticated copy propagation scheme.
Configuration menu - View commit details
-
Copy full SHA for 89c3582 - Browse repository at this point
Copy the full SHA 89c3582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c7046e - Browse repository at this point
Copy the full SHA 8c7046eView commit details
Commits on Nov 8, 2020
-
Collapse all uses of
target.options.foo
intotarget.foo
with an eye on merging `TargetOptions` into `Target`. `TargetOptions` as a separate structure is mostly an implementation detail of `Target` construction, all its fields logically belong to `Target` and available from `Target` through `Deref` impls.
Configuration menu - View commit details
-
Copy full SHA for bf66988 - Browse repository at this point
Copy the full SHA bf66988View commit details -
rustc_target: Rename some target options to avoid tautology
`target.target_endian` -> `target.endian` `target.target_c_int_width` -> `target.c_int_width` `target.target_os` -> `target.os` `target.target_env` -> `target.env` `target.target_vendor` -> `target.vendor` `target.target_family` -> `target.os_family` `target.target_mcount` -> `target.mcount`
Configuration menu - View commit details
-
Copy full SHA for dc004d4 - Browse repository at this point
Copy the full SHA dc004d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f91175 - Browse repository at this point
Copy the full SHA 7f91175View commit details
Commits on Nov 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f173957 - Browse repository at this point
Copy the full SHA f173957View commit details -
comment means to refer to the macro in its direct scope
o752d authoredNov 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 21f44fb - Browse repository at this point
Copy the full SHA 21f44fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2633e93 - Browse repository at this point
Copy the full SHA 2633e93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 868aa89 - Browse repository at this point
Copy the full SHA 868aa89View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf982a5 - Browse repository at this point
Copy the full SHA bf982a5View commit details -
Add missing newline to error message of the default OOM hook
hyd-dev committedNov 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 70e175b - Browse repository at this point
Copy the full SHA 70e175bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0242f96 - Browse repository at this point
Copy the full SHA 0242f96View commit details
Commits on Nov 10, 2020
-
(rustdoc) [src] link for types defined by macros shows invocation
Previously the [src] link on types defined by a macro pointed to the macro definition. This commit makes the Clean-Implementation for Spans aware of macro defined types, so that the link points to the invocation instead.
Configuration menu - View commit details
-
Copy full SHA for 7beb0da - Browse repository at this point
Copy the full SHA 7beb0daView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf06d8 - Browse repository at this point
Copy the full SHA aaf06d8View commit details -
Update src/test/ui/issues/issue-76547.rs
Co-authored-by: Camelid <camelidcamel@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6be4847 - Browse repository at this point
Copy the full SHA 6be4847View commit details -
Configuration menu - View commit details
-
Copy full SHA for 857dd8b - Browse repository at this point
Copy the full SHA 857dd8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d757ecd - Browse repository at this point
Copy the full SHA d757ecdView commit details -
Rollup merge of #76765 - guswynn:async_return, r=tmandry
Make it more clear what an about async fn's returns when referring to what it returns see #76547 This is *likely* not the ONLY place that this happens to be unclear, but we can move this fn to rustc_middle or something like that and reuse it if need be, to apply it to more diagnostics One outstanding question I have is, if the fn returns (), should I make the message more clear (what about `fn f()` vs `fn f() -> ()`, can you tell those apart in the hir?) R? `@tmandry` `@rustbot` modify labels +A-diagnostics +T-compiler
Configuration menu - View commit details
-
Copy full SHA for 9596e34 - Browse repository at this point
Copy the full SHA 9596e34View commit details -
Rollup merge of #78574 - sasurau4:test/check-pass-regions, r=jyn514
Use check-pass instead of build-pass in regions ui test suite ## Overview Helps with #62277 Region inference have nothing to do with codegen because they are erased before codegen. Ref: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Is.20region.20inference.20.20nothing.20to.20do.20with.20codegen.20process.3F/near/215956759
Configuration menu - View commit details
-
Copy full SHA for 8c88c03 - Browse repository at this point
Copy the full SHA 8c88c03View commit details -
Rollup merge of #78669 - sasurau4:test/check-pass-consts, r=jyn514
Use check-pass instead of build-pass in some consts ui test suits Helps with #62277 Changed tests modified by #57175 because of the stabilization `#![feature(const_let)]`. They should be compile-fail because the feature gate checking disallow the feature before stabilization. So the feature gate checking have nothing to do with codegen according to https://rustc-dev-guide.rust-lang.org/feature-gate-ck.html.
Configuration menu - View commit details
-
Copy full SHA for 3a2cbe6 - Browse repository at this point
Copy the full SHA 3a2cbe6View commit details -
Rollup merge of #78847 - tmiasko:inline-return-place, r=matthewjasper
Assert that a return place is not used for indexing during integration The inliner integrates call destination place with callee return place by remapping the local and adding extra projections as necessary. If a call destination place contains any projections (which is already possible) and a return place is used in an indexing projection (most likely doesn't happen yet) the end result would be incorrect. Add an assertion to ensure that potential issue won't go unnoticed in the presence of more sophisticated copy propagation scheme.
Configuration menu - View commit details
-
Copy full SHA for 9c48688 - Browse repository at this point
Copy the full SHA 9c48688View commit details -
Rollup merge of #78854 - the8472:workaround-normalization-regression-…
…master, r=Mark-Simulacrum Workaround for "could not fully normalize" ICE Workaround for "could not fully normalize" ICE (#78139) by removing the `needs_drop::<T>()` calls triggering it. Corresponding beta PR: #78845 Fixes #78139 -- the underlying bug is likely not fixed but we don't have another test case isolated for now, so closing.
Configuration menu - View commit details
-
Copy full SHA for e15fee9 - Browse repository at this point
Copy the full SHA e15fee9View commit details -
Rollup merge of #78875 - petrochenkov:cleantarg, r=Mark-Simulacrum
rustc_target: Further cleanup use of target options Follow up to #77729. Implements items 2 and 4 from the list in #77729 (comment). The first commit collapses uses of `target.options.foo` into `target.foo`. The second commit renames some target options to avoid tautology: `target.target_endian` -> `target.endian` `target.target_c_int_width` -> `target.c_int_width` `target.target_os` -> `target.os` `target.target_env` -> `target.env` `target.target_vendor` -> `target.vendor` `target.target_family` -> `target.os_family` `target.target_mcount` -> `target.mcount` r? `@Mark-Simulacrum`
Configuration menu - View commit details
-
Copy full SHA for 105f4b8 - Browse repository at this point
Copy the full SHA 105f4b8View commit details -
Rollup merge of #78887 - camelid:dataflow-state-decl, r=jonas-schievink
Add comments to explain memory usage optimization Add explanatory comments so that people understand that it's just an optimization and doesn't affect behavior.
Configuration menu - View commit details
-
Copy full SHA for a08e7af - Browse repository at this point
Copy the full SHA a08e7afView commit details -
Rollup merge of #78890 - o752d:patch-2, r=jyn514
comment attribution fix comment means to refer to the macro in its direct scope
Configuration menu - View commit details
-
Copy full SHA for 1952f04 - Browse repository at this point
Copy the full SHA 1952f04View commit details -
Rollup merge of #78896 - cyqsimon:master, r=m-ou-se
Clarified description of write! macro Reordered the list of arguments in the description to match that in the actual macro. Suggested and discussed [here](https://discord.com/channels/442252698964721669/443492145567891458/774341262609219624).
Configuration menu - View commit details
-
Copy full SHA for 87ecb0a - Browse repository at this point
Copy the full SHA 87ecb0aView commit details -
Rollup merge of #78897 - hyd-dev:alloc-error-hook-newline, r=m-ou-se
Add missing newline to error message of the default OOM hook Currently the default OOM hook in libstd does not end the error message with a newline: ``` memory allocation of 4 bytes failedtimeout: the monitored command dumped core /playground/tools/entrypoint.sh: line 11: 7 Aborted timeout --signal=KILL ${timeout} "$`@"` ``` https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=030d8223eb57dfe47ef157709aa26542 This is because the `fmt::Arguments` passed to `dumb_print()` does not end with a newline. All other calls to `dumb_print()` in libstd pass a `\n`-ended `fmt::Arguments` to `dumb_print()`. For example: https://github.com/rust-lang/rust/blob/25f6938da459a57b43bdf16ed6bdad3225b2a3ce/library/std/src/sys_common/util.rs#L18 I think the `\n` was forgotten in #51264. This PR appends `\n` to the error string. ~~Note that I didn't add a test, because I didn't find tests for functions in ` library/std/src/alloc.rs` or a test that is similar to the test of this change would be.~~ *Edit: CI told me there is an existing test. Sorry.*
Configuration menu - View commit details
-
Copy full SHA for 354098c - Browse repository at this point
Copy the full SHA 354098cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b27f0d - Browse repository at this point
Copy the full SHA 6b27f0dView commit details -
Rollup merge of #78908 - liketechnik:fix_macro_expand_src_link, r=jyn514
(rustdoc) [src] link for types defined by macros shows invocation, not defintion Previously the [src] link on types defined by a macro pointed to the macro definition. This pr makes the Clean-Implementation for Spans aware of macro defined types, so that the link points to the invocation instead. I'm not totally sure if it's okay to add the 'macro awareness' in the Clean-Implementation, because it erases that knowledge for all following code. Maybe it would be more sensible to add the check only for the link generation at https://github.com/rust-lang/rust/blob/25f6938da459a57b43bdf16ed6bdad3225b2a3ce/src/librustdoc/html/render/mod.rs#L1619 Closes #39726.
Configuration menu - View commit details
-
Copy full SHA for a5f549e - Browse repository at this point
Copy the full SHA a5f549eView commit details -
Rollup merge of #78910 - tmiasko:intrinsics-link, r=jyn514
Fix links to stabilized versions of some intrinsics
Configuration menu - View commit details
-
Copy full SHA for 42fae6b - Browse repository at this point
Copy the full SHA 42fae6bView commit details -
Rollup merge of #78912 - JulianKnodt:mcg_macro, r=lcnr
Add macro test for min-const-generics Adds a test which uses a macro inside a block for a const-expression, as per #78433 r? `@lcnr`
Configuration menu - View commit details
-
Copy full SHA for fa4d0f2 - Browse repository at this point
Copy the full SHA fa4d0f2View commit details