Commits on Nov 14, 2020

1. Move likely/unlikely argument outside of invisible unsafe block …

   The previous `likely!`/`unlikely!` macros were unsound because it
   permits the caller's expr to contain arbitrary unsafe code.
   
       pub fn huh() -> bool {
           likely!(std::ptr::read(&() as *const () as *const bool))
       }
   
   Before: compiles cleanly.
   After:
   
       error[E0133]: call to unsafe function is unsafe and requires unsafe function or block
          |
       70 |     likely!(std::ptr::read(&() as *const () as *const bool))
          |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function
          |
          = note: consult the function's documentation for information on how to avoid undefined behavior

   

   dtolnay committed Nov 14, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for afb8170
   • Browse repository at this point

   Copy the full SHA

   afb8170 View commit details

   Browse the repository at this point in the history