Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTreeMap: try to enhance various comments #79363

Merged
merged 1 commit into from
Nov 29, 2020

Conversation

ssomers
Copy link
Contributor

@ssomers ssomers commented Nov 23, 2020

All in internal documentation, propagating the "key-value pair" notation from public documentation.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2020
@jeffparsons
Copy link
Contributor

@ssomers As someone who once tried, and ultimately failed to extend Rust's BTreeMap (I took a swing at implementing a cursor API, naively thinking I could smash it out in a couple of spare evenings), I really appreciate this long campaign of PRs in the area — especially the documentation and organisation improvements! 💖

Can I ask, is this building towards a specific goal? I.e. are you cleaning things up on your way to implementing some RFC?

@ssomers
Copy link
Contributor Author

ssomers commented Nov 25, 2020

@jeffparsons It started as a challenge, now I mostly try to get past it, but what else is there to do these days.

@ssomers
Copy link
Contributor Author

ssomers commented Nov 28, 2020

added some of the (slightly conflicting, in git's sense of the word) findings in #79347

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

This is great!

@bors
Copy link
Contributor

bors commented Nov 28, 2020

📌 Commit d1a2c0f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 28, 2020
…ark-Simulacrum

BTreeMap: try to enhance various comments

All in internal documentation, propagating the "key-value pair" notation from public documentation.

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#79327 (Require allocator to be static for boxed `Pin`-API)
 - rust-lang#79340 (Rename "stability" CSS class to "item-info" and combine `document_stability` with `document_short`)
 - rust-lang#79363 (BTreeMap: try to enhance various comments)
 - rust-lang#79395 (Move ui if tests from top-level into `expr/if`)
 - rust-lang#79443 (Improve rustdoc JS tests error output)
 - rust-lang#79464 (Extend doc keyword feature by allowing any ident)
 - rust-lang#79484 (add enable-full-tools to freebsd builds to prevent occasional link er…)
 - rust-lang#79505 (Cleanup: shorter and faster code)
 - rust-lang#79514 (Add test for issue rust-lang#54121: order dependent trait bounds)
 - rust-lang#79516 (Remove unnecessary `mut` binding)
 - rust-lang#79528 (Fix a bootstrap comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfa854d into rust-lang:master Nov 29, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 29, 2020
@ssomers ssomers deleted the btree_cleanup_comments branch November 29, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants