Rollup of 12 pull requests #84405
Closed
Rollup of 12 pull requests #84405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCryptGenRandom isn't available on XP, but we dropped XP support a while ago.
This makes Rustdoc titles for items read like "x in cratename::blah::foo - Rust". Title for modules and other non-items are unchanged, and still read like "doccratenameconst::blah::foo - Rust". This makes managing several open Rustdoc tabs easier. Closes rust-lang#84371.
Replace all `fmt.pad` with `debug_struct`
This replaces any occurrence of:
- `f.pad("X")` with `f.debug_struct("X").finish()`
- `f.pad("X { .. }")` with `f.debug_struct("X").finish_non_exhaustive()`
This is in line with existing formatting code such as
https://github.com/rust-lang/rust/blob/125505306744a0a5bb01d62337260a95d9ff8d57/library/std/src/sync/mpsc/mod.rs#L1470-L1475
…olnay Use BCryptGenRandom instead of RtlGenRandom on Windows. This removes usage of RtlGenRandom on Windows, in favour of BCryptGenRandom. BCryptGenRandom isn't available on XP, but we dropped XP support a while ago.
Move `sys::vxworks` code to `sys::unix` Follow-up to rust-lang#77666, `sys::vxworks` is almost identical to `sys::unix`, the only differences are the `rand`, `thread_local_dtor`, and `process` implementation. Since `vxworks` is `target_family = unix` anyway, there is no reason for the code not to live inside of `sys::unix` like all the other unix-OSes. https://github.com/rust-lang/rust/blob/e41f378f825488a537b024fc3ed599d9c12fda96/compiler/rustc_target/src/spec/vxworks_base.rs#L12 `@rustbot` label: +T-libs-impl
Replace `Void` in `sys` with never type
This PR replaces several occurrences in `sys` of the type `enum Void {}` with the Rust never type (`!`).
The name `Void` is unfortunate because in other languages (C etc.) it refers to a unit type, not an uninhabited type.
Note that the previous stabilization of the never type was reverted, however all uses here are implementation details and not publicly visible.
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
Document that `index` and `index_mut` can panic I thought this was noteworthy and I think a bit more explicitness does no harm.
…trochenkov Improve the docstrings of the `Lto` struct. This change is the result of [this zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Making.20sense.20of.20LTO.20modes.20in.20rustc). Hopefully it makes things a little clearer. What do you think?
Fix broken doc link
…=jackh726 Add GAT related tests Closes rust-lang#79949 Closes rust-lang#79636 Closes rust-lang#78671 Closes rust-lang#70303 Closes rust-lang#70304 Closes rust-lang#71176
Write Rustdoc titles like "x in crate::mod - Rust" This makes Rustdoc titles for items be like "Widget in cratename::blah::foo - Rust". Titles for modules and other non-items are unchanged, and still read like "cratename::blah::foo - Rust". This makes managing several open Rustdoc tabs easier.  This also adds some tests for the new title behavior. Closes rust-lang#84371.
…ithout-fields-a-little-bit-less-verbose, r=kennytm
Format `Struct { .. }` on one line even with `{:#?}`.
The result of `debug_struct("A").finish_non_exhaustive()` before this change:
```
A {
..
}
```
And after this change:
```
A { .. }
```
If there's any fields, the result stays unchanged:
```
A {
field: value,
..
}
…, r=jyn514 Support `x.py doc std --open` I usually run this command: ``` ./x.py doc std --stage 1 --jobs 8 ``` Then I gave a try to `--open` and realized it wasn't working. I finally realized it was simply because it was only handling paths starting with `library`. This PR allows to handle both kinds of paths. cc `@jyn514` r? `@Mark-Simulacrum`
|
@bors r+ rollup=never p=12 |
|
📌 Commit 2cb8146 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
the
S-waiting-on-bors
|
@bors treeclosed- |
|
⌛ Testing commit 2cb8146 with merge 0a1c373d1bb83d1ac80726efca315406b26dc319... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
fmt.padwithdebug_struct#84013 (Replace allfmt.padwithdebug_struct)sys::vxworkscode tosys::unix#84119 (Movesys::vxworkscode tosys::unix)Voidinsyswith never type #84212 (ReplaceVoidinsyswith never type)indexandindex_mutcan panic #84301 (Document thatindexandindex_mutcan panic)Ltostruct. #84365 (Improve the docstrings of theLtostruct.)Struct { .. }on one line even with{:#?}. #84390 (FormatStruct { .. }on one line even with{:#?}.)x.py doc std --open#84393 (Supportx.py doc std --open)Failed merges:
sys_common::poisontosync::poison#84387 (Movesys_common::poisontosync::poison)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup