add an example to explain std::io::Read::read returning 0 in some cases #85288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
the example focuses on Linux, but that should be enough to explain how the behaviour can change
|
Thanks for adding this comment. FWIW, I found it informative: I learned something I didn't know about files, and also I understand the reason for the "intermittent 0" behavior better. |
|
@bors r+ rollup |
|
📌 Commit 95ccdb1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#84758 (MSVC: Avoid using jmp stubs for dll function imports) - rust-lang#85288 (add an example to explain std::io::Read::read returning 0 in some cases) - rust-lang#85334 (Add doc aliases to `unit`) - rust-lang#85525 (Fix my mailmap entry) - rust-lang#85571 (Remove surplus prepend LinkedList fn) - rust-lang#85575 (Fix auto-hide for implementations and implementors.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have always found the explanation about
Read::readreturning 0 to indicate EOF but not indefinitely, so here's more info using Linux as example. I can also add example code if necessary