Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "List trait impls before methods from deref in the sidebar ..." #86564

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Jun 23, 2021

This reverts commit 8a05892.

Fixes #85618

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 23, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2021

📌 Commit 093e246 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 23, 2021
@bors
Copy link
Contributor

bors commented Jun 23, 2021

⌛ Testing commit 093e246 with merge 2ce052b...

@bors
Copy link
Contributor

bors commented Jun 23, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 2ce052b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2021
@bors bors merged commit 2ce052b into rust-lang:master Jun 23, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 23, 2021
@GuillaumeGomez GuillaumeGomez added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2021
@jsha jsha deleted the revert-83826 branch June 25, 2021 17:54
@jsha
Copy link
Contributor Author

jsha commented Jun 25, 2021

I'd like to see this backported into beta, since it affects the sidebar display of methods on String and Vec in the stdlib docs, and I think will have a substantive impact on people's doc-reading experience if it lands in stable.

@apiraino
Copy link
Contributor

apiraino commented Jul 1, 2021

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 1, 2021
@cuviper cuviper mentioned this pull request Jul 2, 2021
@cuviper cuviper modified the milestones: 1.55.0, 1.54.0 Jul 2, 2021
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 2, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2021
[beta] backports

- rustfmt: load nested out-of-line mods correctly rust-lang#86424
- Re-add support for parsing (and pretty-printing) inner-attributes in match body rust-lang#85193
- Revert "List trait impls before methods from deref in the sidebar ..." rust-lang#86564
- Revert "Don't load all extern crates unconditionally" rust-lang#85749

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: "Methods from Deref<...>" too low on sidebar
8 participants