Document rustfmt on nightly-rustc #86737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-bootstrap
|
Some changes occurred in src/tools/rustfmt. |
rust-highfive
added
the
S-waiting-on-review
|
See https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/rustdoc.20is.20using.20rustc_ast_pretty.2C.20would.20.E2.80.A6.20compiler-team.23403 for the motivation - rustdoc is considering using rustfmt as a library. |
jyn514
commented
Jun 30, 2021
Comment on lines
-640
to
-641
| // Build rustdoc. | ||
| builder.ensure(tool::Rustdoc { compiler }); |
There was a problem hiding this comment.
This wasn't actually necessary - rustdoc is built in the step before when Rustc is documented.
This comment has been minimized.
This comment has been minimized.
|
Seems reasonable to me -- r=me with CI fixed (looks like rustfmt failure). |
Mark-Simulacrum
added
S-waiting-on-author
The recursion_limit attribute avoids the following error: ``` error[E0275]: overflow evaluating the requirement `std::ptr::Unique<rustc_ast::Pat>: std::marker::Send` | = help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`rustfmt_nightly`) ```
|
@bors r=Mark-Simulacrum |
|
📌 Commit 01cf0bd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#85749 (Revert "Don't load all extern crates unconditionally") - rust-lang#86714 (Add linked list cursor end methods) - rust-lang#86737 (Document rustfmt on nightly-rustc) - rust-lang#86776 (Skip layout query when computing integer type size during mangling) - rust-lang#86797 (Stabilize `Bound::cloned()`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…items, r=jyn514 Document rustdoc with `--document-private-items` The `tool_doc` macro introduced in rust-lang#86737 did not use `false` as the default value for `binary` when it is not provided, so the `if` is not even expanded and thus the argument is never provided if the `binary` argument isn't. Resolves rust-lang#86900 r? `@Mark-Simulacrum`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…items, r=jyn514 Document rustdoc with `--document-private-items` The `tool_doc` macro introduced in rust-lang#86737 did not use `false` as the default value for `binary` when it is not provided, so the `if` is not even expanded and thus the argument is never provided if the `binary` argument isn't. Resolves rust-lang#86900 r? ``@Mark-Simulacrum``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2021
…items, r=jyn514 Document rustdoc with `--document-private-items` The `tool_doc` macro introduced in rust-lang#86737 did not use `false` as the default value for `binary` when it is not provided, so the `if` is not even expanded and thus the argument is never provided if the `binary` argument isn't. Resolves rust-lang#86900 r? ```@Mark-Simulacrum```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recursion_limitmacro to avoid overflow errorsThis does not currently pass --document-private-items for rustfmt due to rust-lang/cargo#8422 (comment).
r? @Mark-Simulacrum cc @calebcartwright