Clean up the lowering of AST items #88445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit e395715c0ca8f0eb0fb057272c15c199ae5073db has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #88208) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
inquisitivecrystal
force-pushed
the
ast-lowering
branch
from
e395715
to
147f74a
Compare
|
Rebased! |
inquisitivecrystal
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 147f74a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#85017 (Add carrying_add, borrowing_sub, widening_mul, carrying_mul methods to integers) - rust-lang#86362 (Avoid cloning LocalDecls) - rust-lang#88391 (Fix json tuple struct enum variant ) - rust-lang#88399 (Disallow the aapcs CC on Aarch64) - rust-lang#88418 (Allow `~const` bounds on trait assoc functions) - rust-lang#88445 (Clean up the lowering of AST items) - rust-lang#88495 (Add `TcpStream::set_linger` and `TcpStream::linger`) - rust-lang#88501 (Use right span in prelude collision suggestions with macros. ) - rust-lang#88504 (Keep turbofish in prelude collision lint.) - rust-lang#88524 (Remove unnecessary `mut` from udp doctests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies and improves
rustc_ast_lowering::itemin various minor ways. The reasons for the changes should mostly be self evident, though I'm happy to specifically explain anything if needed.These changes used to be part of #88019, but I removed them after it was pointed out that some of my other changes to
rustc_ast_loweringwere unnecessary. It felt like a bad idea to clean up code which I didn't even need to touch anymore.r? @cjgillot