Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #88874

Closed
wants to merge 40 commits into from

Commits on Sep 5, 2021

  1. Don't build the library and standard library before documenting them

    Rustdoc doesn't require the build artifacts to generate the docs, and
    especially in the case of rustc, it greatly increases the time needed to
    run the build.
    jyn514 committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    04db063 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Do not unshallow -- already done by other code

    backport-of: none
    Mark-Simulacrum committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    76e09eb View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Rework DepthFirstSearch API

    This expands the API to be more flexible, allowing for more visitation patterns
    on graphs. This will be useful to avoid extra datasets (and allocations) in
    cases where the expanded DFS API is sufficient.
    
    This also fixes a bug with the previous DFS constructor, which left the start
    node not marked as visited (even though it was immediately returned).
    nikomatsakis authored and Mark-Simulacrum committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    c9d46eb View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. WIP state

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2987f4b View commit details
    Browse the repository at this point in the history
  2. as casts and block exprs

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9b29138 View commit details
    Browse the repository at this point in the history
  3. dont support blocks

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4483c2b View commit details
    Browse the repository at this point in the history
  4. bless stderr

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    47b16f4 View commit details
    Browse the repository at this point in the history
  5. tidy

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    c170dcf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    08e8644 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc63e9a View commit details
    Browse the repository at this point in the history
  8. handle ExprKind::NeverToAny

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4cbcb09 View commit details
    Browse the repository at this point in the history
  9. remove WorkNode

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1f57f8b View commit details
    Browse the repository at this point in the history
  10. remove debug stmts

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    15101c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    406d2ab View commit details
    Browse the repository at this point in the history
  12. remove comment

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    79be080 View commit details
    Browse the repository at this point in the history
  13. nits

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    955e2b2 View commit details
    Browse the repository at this point in the history
  14. add a CastKind to Node::Cast

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8c7954d View commit details
    Browse the repository at this point in the history
  15. resolve from_hir_call FIXME

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    3212734 View commit details
    Browse the repository at this point in the history
  16. fmt

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    cd2915e View commit details
    Browse the repository at this point in the history
  17. CI please

    BoxyUwU committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    fd9bb30 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c86c634 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    8295e4a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Remove unnecessary Cache.*_did fields

    They can be obtained by accessing the `TyCtxt` where they are needed.
    camelid committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    44e6f2e View commit details
    Browse the repository at this point in the history
  2. rustc: Remove local variable IDs from Exports

    Local variables can never be exported.
    petrochenkov committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    294510e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Configuration menu
    Copy the full SHA
    03f9fe2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df281ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0bb1c28 View commit details
    Browse the repository at this point in the history
  4. Create a valid Res in external_path()

    The order of the `where` bounds on auto trait impls changed because
    rustdoc currently sorts auto trait `where` bounds based on the `Debug`
    output for the bound. Now that the bounds have an actual `Res`, they are
    being unintentionally sorted by their `DefId` rather than their path.
    So, I had to update a test for the change in ordering of the rendered
    bounds.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    6a84d34 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2207f5 View commit details
    Browse the repository at this point in the history
  6. Fix redundant arguments in external_path()

    If the path is for a trait, it is always true that `trait_did ==
    Some(did)`, so instead, `external_path()` now takes an `is_trait`
    boolean.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    5321b35 View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary is_trait argument

    It was only used for sugaring `Fn` trait bounds, and rustdoc already
    checks that the `did` is for a `Fn` (or `FnMut`, `FnOnce`) lang item,
    so it's not necessary to also check that the `did` belongs to a trait.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    913764d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    280fc2d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. Rollup merge of rust-lang#88675 - jyn514:faster-doc, r=Mark-Simulacrum

    Don't build the compiler and standard library before documenting them
    
    Rustdoc doesn't require the build artifacts to generate the docs, and
    especially in the case of rustc, it greatly increases the time needed to
    run the build.
    
    r? ```@Mark-Simulacrum``` cc ```@steffahn```
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    f00af15 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#88677 - petrochenkov:exportid, r=davidtwco

    rustc: Remove local variable IDs from `Export`s
    
    Local variables can never be exported.
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    68bb06a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#88699 - Mark-Simulacrum:fixes-cherry-picker…

    …, r=pietroalbini
    
    Remove extra unshallow from cherry-pick checker
    
    This is already done by https://github.com/rust-lang/rust/blob/13db8440bbbe42870bc828d4ec3e965b38670277/src/ci/init_repo.sh#L32-L36 on the beta channel, and git throws an error if you attempt to unshallow an already non-shallow repository.
    
    r? `@pietroalbini`
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    ae14fc4 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#88709 - BoxyUwU:thir-abstract-const, r=lcnr

    generic_const_exprs: use thir for abstract consts instead of mir
    
    Changes `AbstractConst` building to use `thir` instead of `mir` so that there's less chance of consts unifying when they shouldn't because lowering to mir dropped information (see `abstract-consts-as-cast-5.rs` test)
    
    r? `@lcnr`
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4972d14 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#88711 - Mark-Simulacrum:fix-dfs-bug, r=jack…

    …h726
    
    Rework DepthFirstSearch API
    
    This expands the API to be more flexible, allowing for more visitation patterns
    on graphs. This will be useful to avoid extra datasets (and allocations) in
    cases where the expanded DFS API is sufficient.
    
    This also fixes a bug with the previous DFS constructor, which left the start
    node not marked as visited (even though it was immediately returned).
    
    Commit written by `@nikomatsakis` originally, cherry picked from several commits in work on never type stabilization, but stands alone.
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    543b8c0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#88745 - hnj2:allow-trait-impl-missing-code,…

    … r=GuillaumeGomez
    
    Allow missing code examples in trait impls.
    
    Excludes Trait implementations from the items that need to have doc code examples when using the `rustdoc::missing_doc_code_examples` lint.
    
    For details see rust-lang#88741
    
    fixes rust-lang#88741
    
    r? ``@jyn514``
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    c134e96 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#88810 - camelid:cleanup-pt1, r=jyn514

    rustdoc: Cleanup `clean` part 1
    
    Split out from rust-lang#88379.
    
    These commits are completely independent of each other, and each is a fairly
    small change (the last few are new commits; they are not from rust-lang#88379):
    
    - Remove unnecessary `Cache.*_did` fields
    - rustdoc: Get symbol for `TyParam` directly
    - Create a valid `Res` in `external_path()`
    - Remove unused `hir_id` parameter from `resolve_type`
    - Fix redundant arguments in `external_path()`
    - Remove unnecessary `is_trait` argument
    - rustdoc: Cleanup a pattern match in `external_generic_args()`
    
    r? `@jyn514`
    Manishearth authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    49a7f5f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d6b179b View commit details
    Browse the repository at this point in the history