rustdoc: Pretty-print assoc const defaults on-demand

[camelid]

This should improve performance, clean up the code, and help pave the
way for #83035.

[rust-highfive]

Some changes occurred in clean/types.rs.

cc @camelid

[rust-highfive]

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

[camelid]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit caec282fdf3aa37367933dcdffbb6f7bf785519f with merge 146ad07df7795b01adada901a9d9581d2bfbb6fd...

[camelid]

@bors rollup=never

[camelid]

I ran tests locally, so should be good now.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 719d7a5 with merge 14d26c019a4f5cc06517d5296e7a8a0712175082...

[bors]

☀️ Try build successful - checks-actions
Build commit: 14d26c019a4f5cc06517d5296e7a8a0712175082 (14d26c019a4f5cc06517d5296e7a8a0712175082)

[rust-timer]

Queued 14d26c019a4f5cc06517d5296e7a8a0712175082 with parent 928783d, future comparison URL.

[rust-timer]

Finished benchmarking commit (14d26c019a4f5cc06517d5296e7a8a0712175082): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[GuillaumeGomez]

Thanks!

@bors: r+

[bors]

📌 Commit 719d7a5 has been approved by GuillaumeGomez

[bors]

⌛ Testing commit 719d7a5 with merge 4cc3158620cf9447a02ba755394cd7e79eedd2b6...

[bors]

💥 Test timed out

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[camelid]

Pretty sure that's spurious, so @bors retry

[bors]

⌛ Testing commit 719d7a5 with merge 16d8a91...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 16d8a91 to master...

[rust-timer]

Finished benchmarking commit (16d8a91): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

• Very large improvement in instruction counts (up to -6.8% on incr-unchanged builds of ctfe-stress-4)
• Very large regression in instruction counts (up to 14.3% on incr-unchanged builds of tuple-stress)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

[camelid]

@rylev rustc-perf is reporting extreme, spurious perf changes.

[camelid]

Hopefully those shouldn't happen again now that rust-lang/rustc-perf#1123 is merged?