Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: don't clone already owned Path and modify it inplace #91833

Merged
merged 1 commit into from
Dec 16, 2021
Merged

rustdoc: don't clone already owned Path and modify it inplace #91833

merged 1 commit into from
Dec 16, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Dec 12, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2021
klensy
klensy commented Dec 12, 2021
View reviewed changes
src/librustdoc/clean/auto_trait.rs
.map(|bounds| bounds.contains(&strip_path_generics(trait_.clone())))
.map(|bounds| bounds.contains(&strip_path_generics(trait_)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we get fresh Path from get_trait_path() so no need to clone in again

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 12, 2021
jyn514
jyn514 approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with CI passing :)

@jyn514
Copy link
Member

jyn514 commented Dec 12, 2021

@bors rollup=iffy (affects perf)

@jyn514
Copy link
Member

jyn514 commented Dec 12, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2021

📌 Commit 8869dbc has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@camelid camelid mentioned this pull request Dec 12, 2021
Closed
@camelid
Copy link
Member

camelid commented Dec 15, 2021

This code is likely perf-sensitive, so @bors rollup=never

@bors
Copy link
Contributor

bors commented Dec 16, 2021

⌛ Testing commit 8869dbc with merge 1d01550...

@bors
Copy link
Contributor

bors commented Dec 16, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 1d01550 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2021
@bors bors merged commit 1d01550 into rust-lang:master Dec 16, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 16, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d01550): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -31.9% on incr-unchanged builds of clap-rs)
  • Large regression in instruction counts (up to 4.9% on incr-patched: println builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Dec 16, 2021
@jyn514
Copy link
Member

jyn514 commented Dec 16, 2021

All of that seems wrong 😆

@jyn514
Copy link
Member

jyn514 commented Dec 16, 2021

cc @rylev

@klensy
Copy link
Contributor Author

klensy commented Dec 16, 2021

looking at "regression" at #91996 - this is return of values back. Plus, this is rustdoc-only change, so perf changes for other benches unrelated.

@rylev
Copy link
Member

rylev commented Dec 21, 2021

This seems likely to be noise as a result of the issue tracked in rust-lang/rustc-perf#1126 -- marking as triaged, not something we should address directly.

@rustbot label +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
9 participants
@klensy @rust-highfive @jyn514 @bors @camelid @rust-timer @rylev @GuillaumeGomez @rustbot