Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #94254

Merged
merged 19 commits into from
Feb 22, 2022
Merged

Rollup of 7 pull requests #94254

merged 19 commits into from
Feb 22, 2022

Commits on Feb 20, 2022

  1. tidy: fire less "ignoring file length unneccessarily" warnings

    This avoids a situation where a file is at the border of the limit,
    and alternates between hitting the limit and not hitting it, causing
    a back and forth of addition of the ignore-tidy-linelength directive.
    
    As an example, consider the ignore-tidy-filelength of compiler/rustc_typeck/src/collect.rs.
    
    It was added in 2ca4964, removed in
    37354eb, added again in 448d076,
    removed in 3171bd5, added in 438826f,
    and rust-lang#94142 is going to remove it again.
    
    To avoid this back and forth, we exempt files from the unneccessary
    ignoring warning that have length of at least 70% of the limit.
    est31 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    49a5456 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f810314 View commit details
    Browse the repository at this point in the history
  3. compiletest: Print process output info with less whitespace

    Before:
    
    ```
    error: jsondocck failed!
    status: exit status: 1
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/jsondocck" "--doc-dir" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--template" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    stdout:
    ------------------------------------------
    
    ------------------------------------------
    stderr:
    ------------------------------------------
    Invalid command: Tried to use the previous path in the first command on line 10
    Error: "Jsondocck failed for /data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    
    ------------------------------------------
    
    Rustdoc Output:
    status: exit status: 0
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait/auxiliary" "-o" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--deny" "warnings" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs" "--output-format" "json" "-Zunstable-options"
    stdout:
    ------------------------------------------
    
    ------------------------------------------
    stderr:
    ------------------------------------------
    
    ------------------------------------------
    
    ```
    
    After:
    
    ```
    
    error: jsondocck failed!
    status: exit status: 1
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/jsondocck" "--doc-dir" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--template" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    stdout: none
    --- stderr -------------------------------
    Invalid command: Tried to use the previous path in the first command on line 10
    Error: "Jsondocck failed for /data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    ------------------------------------------
    
    Rustdoc Output:
    status: exit status: 0
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait/auxiliary" "-o" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--deny" "warnings" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs" "--output-format" "json" "-Zunstable-options"
    stdout: none
    stderr: none
    
    ```
    aDotInTheVoid committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    c97f05c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Expand let-else allow tests

    The #[allow(...)] directive was tested for the body and the pattern,
    but non-presence of it wasn't tested. Furthermore, it wasn't tested
    for the expression. We add expression tests as well as ones checking
    the non-presence of the directive.
    est31 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    e7730dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bd7106 View commit details
    Browse the repository at this point in the history
  3. Simplify gating of BPF w registers behind the alu32 target feature

    This is already handled by supported_types().
    Amanieu committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    2e8a766 View commit details
    Browse the repository at this point in the history
  4. On ARM, use relocation_model to detect whether r9 should be reserved

    The previous approach of checking for the reserve-r9 target feature
    didn't actually work because LLVM only sets this feature very late when
    initializing the per-function subtarget.
    Amanieu committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1ceb104 View commit details
    Browse the repository at this point in the history
  5. Take CodegenFnAttrs into account when validating asm! register operands

    Checking of asm! register operands now properly takes function
    attributes such as #[target_feature] and #[instruction_set] into
    account.
    Amanieu committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    fc41d4b View commit details
    Browse the repository at this point in the history
  6. Add tests

    Amanieu committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    fb5539b View commit details
    Browse the repository at this point in the history
  7. Add ignore-tidy-filelength

    Amanieu committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    a60b791 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Configuration menu
    Copy the full SHA
    0626919 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb1ee87 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#94169 - Amanieu:asm_stuff, r=nagisa

    Fix several asm! related issues
    
    This is a combination of several fixes, each split into a separate commit. Splitting these into PRs is not practical since they conflict with each other.
    
    Fixes rust-lang#92378
    Fixes rust-lang#85247
    
    r? ``@nagisa``
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1cf2e69 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#94178 - est31:tolerant_lines_check, r=Mark-…

    …Simulacrum
    
    tidy: fire less "ignoring file length unneccessarily" warnings
    
    This avoids a situation where a file is at the border of the limit,
    and alternates between hitting the limit and not hitting it, causing
    a back and forth of addition of the ignore-tidy-linelength directive.
    
    As an example, consider the ignore-tidy-filelength of compiler/rustc_typeck/src/collect.rs.
    
    It was added in 2ca4964, removed in
    37354eb (a revert of the earlier commit), added again in 448d076,
    removed in 3171bd5, added in 438826f,
    and removed in bb0a2f9.
    
    To avoid this back and forth, we exempt files from the unneccessary
    ignoring warning that have length of at least 70% of the limit.
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    a53b604 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#94179 - devnexen:getexecname_directcall, r=…

    …kennytm
    
    solarish current_exe using libc call directly
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    21fb814 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#94196 - aDotInTheVoid:terse-procres-info, r…

    …=Mark-Simulacrum
    
    compiletest: Print process output info with less whitespace
    
    Before:
    
    ```
    error: jsondocck failed!
    status: exit status: 1
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/jsondocck" "--doc-dir" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--template" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    stdout:
    ------------------------------------------
    
    ------------------------------------------
    stderr:
    ------------------------------------------
    Invalid command: Tried to use the previous path in the first command on line 10
    Error: "Jsondocck failed for /data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    
    ------------------------------------------
    
    Rustdoc Output:
    status: exit status: 0
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait/auxiliary" "-o" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--deny" "warnings" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs" "--output-format" "json" "-Zunstable-options"
    stdout:
    ------------------------------------------
    
    ------------------------------------------
    stderr:
    ------------------------------------------
    
    ------------------------------------------
    
    ```
    
    After:
    
    ```
    
    error: jsondocck failed!
    status: exit status: 1
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage0-tools-bin/jsondocck" "--doc-dir" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--template" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    stdout: none
    --- stderr -------------------------------
    Invalid command: Tried to use the previous path in the first command on line 10
    Error: "Jsondocck failed for /data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs"
    ------------------------------------------
    
    Rustdoc Output:
    status: exit status: 0
    command: "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait/auxiliary" "-o" "/data/ne321/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-json/traits/supertrait" "--deny" "warnings" "/data/ne321/rust/src/test/rustdoc-json/traits/supertrait.rs" "--output-format" "json" "-Zunstable-options"
    stdout: none
    stderr: none
    
    ```
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    1177b30 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#94208 - est31:let_else, r=Mark-Simulacrum

    Add the let else tests found missing in the stabilization report
    
    In the stabilization report of `let else`, in rust-lang#93628, I found various cases which weren't tested. This PR adds them.
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b322382 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#94237 - compiler-errors:dont-wrap-ambiguous…

    …-receivers, r=lcnr
    
    Do not suggest wrapping an item if it has ambiguous un-imported methods
    
    If the method is defined for the receiver we have, but is ambiguous during probe, then it probably comes from one of several traits that just weren't `use`d. Don't suggest wrapping the receiver in `Box`/etc., even if that makes the method probe unambiguous.
    
    Fixes rust-lang#94218
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    396910a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#94246 - RalfJung:hex, r=oli-obk

    ScalarMaybeUninit is explicitly hexadecimal in its formatting
    
    This makes `ScalarMaybeUninit` consistent with `Scalar` after the changes in rust-lang#94189.
    
    r? ``@oli-obk``
    matthiaskrgr authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    e381462 View commit details
    Browse the repository at this point in the history