Rollup of 8 pull requests #94814
Rollup of 8 pull requests #94814
Conversation
This was part of Mark's original PR in rust-lang@ecb424f, but I missed it when writing rust-lang#92260.
This is required after LLVM change 3c4410d (aka https://reviews.llvm.org/D121168) did some includes cleanup.
Better error for normalization errors from parent crates that use `#![feature(generic_const_exprs)]` This PR implements a somewhat rudimentary heuristic to suggest using `#![feature(generic_const_exprs)]` in a child crate when a function from a foreign crate (that may have used `#![feature(generic_const_exprs)]`) fails to normalize during codegen. cc: rust-lang#79018 cc: rust-lang#94287
…ottmcm Document new recommended use of `FromIterator::from_iter` rust-lang#90107 Most of the added prose was paraphrased from the links provided in the issue. The suggested `VecDeque` example seemed to make the point well enough so I just used that.
…ss, r=joshtriplett Fix soundness issue in scoped threads. This was discovered in rust-lang#94559 (comment) The `scope()` function returns when all threads are finished, but I accidentally considered a thread 'finished' before dropping their panic payload or ignored return value. So if a thread returned (or panics with) something that in its `Drop` implementation still uses borrowed stuff, it goes wrong. https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=2a1f19ac4676cdabe43e24e536ff9358
…=notriddle Unify impl blocks by wrapping them into a div The blanket and "auto traits" sections are wrapped into a `div` with an ID. This PR fixes this incoherence by wrapping each impl section (the "deref impl" and the "inherent impl" sections were missing it). It'll also make some tests simpler to write. r? `````@notriddle`````
…GuillaumeGomez Improve rustdoc book This pull-request improves the `rustdoc` book by doing some (light) cleanup, by merging some stuff, by adding some missing stuff (like tracking issues links, for those who had one) and also by moving some chapter's into sub-chapter's to improve the flow of the book. ~~Note that I locally tested with `mdbook-lintcheck` that no links became accidentally broken.~~ (Not enough, ;-)) r? `````@GuillaumeGomez`````
…Simulacrum Allow `cargo run` instead of `cargo run -p bootstrap` This was part of `@Mark-Simulacrum` 's original PR in rust-lang@ecb424f, but I missed it when writing rust-lang#92260. This also has the side effect of allowing `cargo build --bins` instead of `cargo build -p bootstrap --bins`. I'm not sure when you would want to run cargo build/check/test without going through bootstrap, but this still allows you to do so as long as you pass `-p` for all the crates you want to build.
Revert accidental stabilization fixes rust-lang#94804
RustWrapper: add missing include This is required after LLVM change 3c4410d (aka https://reviews.llvm.org/D121168) did some includes cleanup. r? nikic
rustbot
added
T-compiler
|
@bors r+ rollup=never p=8 |
|
📌 Commit 07e4fbd has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5f4e067): comparison url. Summary: This benchmark run shows 10 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
|
@matthiaskrgr looks like this is a very large regression in basically just one test case: cargo opt incremental patch. Looking through the various PRs that make up this rollup, there isn't one that seems like an obvious culprit. Since the regression seems to be in codegen, #94809 might be the one that makes the most sense. It should be pretty easy to revert and test. |
Successful merges:
#![feature(generic_const_exprs)]#94440 (Better error for normalization errors from parent crates that use#![feature(generic_const_exprs)])FromIterator::from_iter#94587 (Document new recommended use ofFromIterator::from_iter)cargo runinstead ofcargo run -p bootstrap#94796 (Allowcargo runinstead ofcargo run -p bootstrap)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup