Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] metadata: Split ModChild into two structures #94854

Closed
wants to merge 1 commit into from
Closed

[WIP] metadata: Split ModChild into two structures #94854

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

to avoid encoding redundant data.

Implement the suggestion from #91795 (comment).
r? @cjgillot

@petrochenkov
metadata: Split ModChild into two structures
530e76d 
to avoid encoding redundant data.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 11, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2022
@bors
Copy link
Contributor

bors commented Mar 11, 2022

⌛ Trying commit 530e76d with merge 15b7cbc9690be475512dc97619c8d4f30ff3c54b...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2022
@bors
Copy link
Contributor

bors commented Mar 11, 2022

☀️ Try build successful - checks-actions
Build commit: 15b7cbc9690be475512dc97619c8d4f30ff3c54b (15b7cbc9690be475512dc97619c8d4f30ff3c54b)

@rust-timer
Copy link
Collaborator

Queued 15b7cbc9690be475512dc97619c8d4f30ff3c54b with parent f58d51b, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15b7cbc9690be475512dc97619c8d4f30ff3c54b): comparison url.

Summary: This benchmark run did not return any relevant results. 18 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 12, 2022
@petrochenkov
Copy link
Contributor Author

Not an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-timer @bors @cjgillot @rust-highfive @rustbot