Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #96495

Merged
merged 19 commits into from
Apr 28, 2022
Merged

Rollup of 7 pull requests #96495

merged 19 commits into from
Apr 28, 2022

Commits on Apr 25, 2022

  1. Configuration menu
    Copy the full SHA
    fc6af81 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Configuration menu
    Copy the full SHA
    843e8d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0bbc78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b367a0 View commit details
    Browse the repository at this point in the history
  4. Avoid producing NoDelim values in Frame.

    The code currently ignores the actual delimiter on the RHS and fakes up
    a `NoDelim`/`DelimSpan::dummy()` one. This commit changes it to use the
    actual delimiter.
    
    The commit also reorders the fields for the `Delimited` variant to match
    the `Sequence` variant.
    nnethercote committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a8e862c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Configuration menu
    Copy the full SHA
    9665da3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86f0117 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae42f22 View commit details
    Browse the repository at this point in the history
  4. TAITs are suggestable

    compiler-errors committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    f9e7489 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    83d701e View commit details
    Browse the repository at this point in the history
  6. tut tut tut

    BoxyUwU committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    f697955 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    beb4e16 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Rollup merge of rust-lang#96377 - compiler-errors:infer-rustfix, r=pe…

    …trochenkov
    
    make `fn() -> _ { .. }` suggestion MachineApplicable
    
    This might not be valid, but it would be nice to promote this to `MachineApplicable` so people can use rustfix here.
    
    Also de65fcf009d07019689cfad7f327667e390a325d is to [restore the suggestion for `issue-77179.rs`](rust-lang@de65fcf#diff-12e43fb5d6d12ec7cb5c6b48204a18d113cf5de0e12eb71a358b639bd9aadaf0R8). (though in this case, the code in that issue still doesn't compile, so it's not marked with rustfix).
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    4a7483c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#96397 - AronParker:issue-96368-fix, r=dtolnay

    Make EncodeWide implement FusedIterator
    
    [`EncodeUtf16`](https://doc.rust-lang.org/std/str/struct.EncodeUtf16.html) and [`EncodeWide`](https://doc.rust-lang.org/std/os/windows/ffi/struct.EncodeWide.html) currently serve similar purposes: They convert from UTF-8 to UTF-16 and WTF-8 to WTF-16, respectively. `EncodeUtf16` wraps a &str, whereas `EncodeWide` wraps an &OsStr.
    
    When Iteration has concluded, these iterators wrap an empty slice, which will forever yield `None` values. Hence, `EncodeUtf16` rightfully implements `FusedIterator`. However, `EncodeWide` in contrast does not, even though it serves an almost identical purpose.
    
    This PR attempts to fix that issue. I consider this change minor and non-controversial, hence why I have not added a RFC/FCP. Please let me know if the stability attribute is wrong or contains a wrong version number. Thanks in advance.
    
    Fixes rust-lang#96368
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c4dd0d3 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#96421 - nnethercote:less-NoDelim, r=petroch…

    …enkov
    
    Less `NoDelim`
    
    Currently there are several places where `NoDelim` (which really means "implicit delimiter" or "invisible delimiter") is used to mean "no delimiter". The name `NoDelim` is a bit misleading, and may be a cause.
    
    This PR changes these places, e.g. by changing a `DelimToken` to `Option<DelimToken>` and then using `None` to mean "no delimiter". As a result, the *only* place where `NoDelim` values are now produced is within:
    - `Delimiter::to_internal()`, when converting from `Delimiter::None`.
    - `FlattenNonterminals::process_token()`, when converting `TokenKind::Interpolated`.
    
    r? ````@petrochenkov````
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    80045d6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#96432 - SparrowLii:dbg_scope, r=davidtwco

    not need `Option` for `dbg_scope`
    
    This PR fixes a few FIXME about not using `Option` in `dbg_scope` field of `DebugScope`, during `create_function_debug_context` func in codegen parts.
    Added a `BitSet<SourceScope>` parameter to `make_mir_scope` to indicate whether the `DebugScope` has been instantiated.
    cc ````@eddyb````
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d956d01 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96466 - compiler-errors:error-collect-array…

    …, r=davidtwco
    
    Better error messages when collecting into `[T; n]`
    
    Fixes rust-lang#96461
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6f6fe3e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96471 - BoxyUwU:let_else_considered_harmful…

    …, r=lcnr
    
    replace let else with `?`
    
    r? `@oli-obk`
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    4c628bb View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96483 - Urgau:check-cfg-target_feature, r=p…

    …etrochenkov
    
    Add missing `target_feature` to the list of well known cfg names
    
    This PR adds the missing `target_feature` cfg name to the list of well known cfg names.
    
    It was notice missing in rust-lang#96472 thanks to `@bjorn3,` the reason being that `--check-cfg=names()` automatically inherit the names passed by `--cfg` (or internal to `rustc`) and is seems that the vast majority of targets have at least one target feature leading to `target_feature` being a well known name in most target but it should always be a well known name so this PR add it unconditionally to list.
    
    r? `@petrochenkov`
    Dylan-DPC authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    89db345 View commit details
    Browse the repository at this point in the history