Harden bad placeholder checks on statics/consts #97508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fabian Wolff <fabian.wolff@alumni.ethz.ch>
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 344feef has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#95211 (Improve parser diagnostics) - rust-lang#95243 (Add Apple WatchOS compile targets) - rust-lang#97385 (Add WIP stable MIR crate) - rust-lang#97508 (Harden bad placeholder checks on statics/consts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #89161
Fixes #88643
In #83739, I added a check for trait objects on statics/consts but it wasn't robust.
is_suggestable_infer_tyfn does a more strict check and finds more bad placeholders. See #89161 (comment) for the more detailed explanation.r? @pnkfelix as you're the reviewer of the previous PR