Teach rustc-fake to tell the truth about subprocess exit statuses #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaahc
commented
Jul 23, 2022
|
nika has also suggested we may also want to make it so |
Mark-Simulacrum
approved these changes
Jul 23, 2022
eddyb
reviewed
Jul 23, 2022
Co-authored-by: Eduard-Mihai Burtescu <edy.burt@gmail.com>
Co-authored-by: Jane Losare-Lusby <jlusby42@gmail.com>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 30, 2022
bump rustc-perf commit split off from rust-lang#99431 needed to access bugfix from rust-lang/rustc-perf#1366
RalfJung
reviewed
Aug 2, 2022
| @@ -467,8 +467,9 @@ fn process_self_profile_output(prof_out_dir: PathBuf, args: &[OsString]) { | |||
| #[cfg(windows)] | |||
| fn exec(cmd: &mut Command) { | |||
There was a problem hiding this comment.
FWIW using return type -> ! (like the Unix version) would have caught this
There was a problem hiding this comment.
Ahh I forgot that part when I posted @mystor's suggestion (#1366 (comment)).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the ci failure observed in rust-lang/rust#99431
turns out the impl of
fn exec()in rustc-perf'srustc-fakeis incorrect on windows and only reports a failure when the subprocess fails to spawn, but if it spawns correctly it always reports success rather than checking the exit status of the subprocess. This causes the probe in anyhow to succeed and enable#[cfg(backtrace)]which then causes anyhow to fail to compile, but because it was inside ofrustc-fakeit reports success and continues! This happens quite a bit and we get some very exciting compiler errors whenRUST_LOG=collector=traceis set.