Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle block comment before Traits in derive attribute (issue 4984) #5002

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Handle block comment before Traits in derive attribute (issue 4984) #5002

merged 2 commits into from
Oct 6, 2021

Commits on Oct 5, 2021

  1. Update derive attibute span to start after opening '(' 

    Fixes 4984

When parsing derive attributes we're only concerned about the traits
and comments listed between the opening and closing parentheses.

Derive attribute spans currently start at the '#'.

    Span starts here
    |
    v
    #[derive(...)]

After this update the derive spans start after the opening '('.

    Span starts here
             |
             V
    #[derive(...)]
    @ytmimi
    ytmimi committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    e12ea9e View commit details
    Browse the repository at this point in the history

  2. Add additional test cases for issue 4984

    @ytmimi
    ytmimi committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    f7cb26f View commit details
    Browse the repository at this point in the history