Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proc macro2 #455

Merged
merged 11 commits into from
May 21, 2018
Merged

Update proc macro2 #455

merged 11 commits into from
May 21, 2018

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented May 21, 2018

Update to the latest version of proc_macro2, quote and syn.

@lu-zero
Copy link
Contributor Author

lu-zero commented May 21, 2018

looks like the new rustfmt has different ideas regarding the style and there is something quite fishy going on windows and x86 but it is unrelated to this set.

This was referenced May 21, 2018
Merged
Closed
@alexcrichton
Copy link
Member

Unfortunately we're hit by a slew of bugs here:

  • First the x86 tests seem to be failing I believe because mergefunc was recently landed. These are presumably duplicates with other functions being generated so they're merged and the disassembly is no longer showing us precisely which instruction is being used.
  • Next proc-macro2 is buggy on nightly, causing the verify-x86 builder to build
  • I think rustfmt with nightly needs to be run again?

@alexcrichton
Copy link
Member

I also don't know what's going on yet with Windows, that's just Linux :(

@alexcrichton
Disable RUST_BACKTRACE by default
80d850b
@alexcrichton
Allow rustfmt failure for now
93b4186
@alexcrichton
Disable proc-macro2 nightly feature in verify-x86
ad67c5d 
Currently this causes bugs on nightly due to upstream rustc bugs, this should be
temporary
@alexcrichton
Copy link
Member

Ok Windows looks back to "normal", I think this PR is now purely blocked on figuring out mergefunc

@alexcrichton
Copy link
Member

Ok I've pushed a commit that will hopefully thwart mergefunc, let's see how it pans out.

@alexcrichton
Copy link
Member

Alright, all green now!

@alexcrichton alexcrichton merged commit 066f0b0 into rust-lang:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-zero @alexcrichton @dtolnay