Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glacier command #949

Merged
merged 3 commits into from
Nov 22, 2020
Merged

Fix glacier command #949

merged 3 commits into from
Nov 22, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 30, 2020

It was fetching the HTML rather than the raw source;
see rust-lang/glacier#530 for an example.

@kellda
Copy link
Contributor

kellda commented Nov 2, 2020

cc rust-lang/glacier#231

@camelid
Copy link
Member Author

camelid commented Nov 22, 2020

@Mark-Simulacrum Could you review this? Thanks!

@Mark-Simulacrum Mark-Simulacrum merged commit fe16faf into rust-lang:master Nov 22, 2020
@camelid camelid deleted the fix-glacier branch November 22, 2020 20:25
@camelid
Copy link
Member Author

camelid commented Nov 22, 2020

Thanks! Looking forward to using the command now :)

@camelid
Copy link
Member Author

camelid commented Nov 22, 2020

Hmm, it doesn't seem to be working: rust-lang/rust#78632 (comment)

@kellda
Copy link
Contributor

kellda commented Nov 22, 2020

Why did you sent the command twice ?

@camelid
Copy link
Member Author

camelid commented Nov 22, 2020

Because the first time it didn't work – you need to include /rust-play/ in the Gist URL, which I had not done. That should probably be fixed too.

@Mark-Simulacrum did you see anything in the logs that would explain why rustbot silently failed?

@kellda
Copy link
Contributor

kellda commented Nov 22, 2020

It probably failed because it wasn't able to recreate a branch with the same name. (The branch having been created by your first command)

See rust-lang/glacier#231 (comment) and rust-lang/glacier#231 (comment)

@Mark-Simulacrum
Copy link
Member

I don't have time right now to track down logs unfortunately, but @kellda's theory looks like the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants