AML: Implement OpReg-relative PkgLength parser #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWoods
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Nice, thanks!
It's not clear to me that having separate PkgLength and RegionPkgLength types provides a huge amount of benefit, since the fields are fairly similar (and we could easily rewrite the constructors to allow both cases) and we don't rely on the type safety to use the right one, but it does make the intention clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #187 by implementing an additional kind of
PkgLength, which is checked against its OperationRegion instead of the AML input slice.