Add p() for Bernoulli
#1481
Open
Add p() for Bernoulli
#1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be a way to obtain the probability of `true`.
|
This does not compile. |
|
Oh god, I pushed the wrong commit! Sorry, will push an actually working one later! |
dhardy
requested changes
Sep 10, 2024
| @@ -20,6 +20,7 @@ You may also find the [Upgrade Guide](https://rust-random.github.io/book/update. | |||
| - Fix portability of `rand::distributions::Slice` (#1469) | |||
| - Rename `rand::distributions` to `rand::distr` (#1470) | |||
| - The `serde1` feature has been renamed `serde` (#1477) | |||
| - Add `p()` for `Bernoulli` to access probability. | |||
| @@ -136,6 +136,16 @@ impl Bernoulli { | |||
| let p_int = ((f64::from(numerator) / f64::from(denominator)) * SCALE) as u64; | |||
| Ok(Bernoulli { p_int }) | |||
| } | |||
|
|
|||
| #[inline] | |||
| /// Returns the probability (`p`) of the distribution. | |||
There was a problem hiding this comment.
This should note that the output is a reconstruction which may differ from the input to Bernoulli::new.
| if self.p_int == ALWAYS_TRUE { | ||
| 1.0 | ||
| } else { | ||
| f64::from(self.p_int) / SCALE |
There was a problem hiding this comment.
Since p_int is constructed in new or from_ratio via as cast from f64, we can safely use as to cast back again (there may be some loss of precision, particularly if a very small value were passed into new).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Add accessor for
Bernoullireturning the probbability oftrueMotivation
There is currently no way to obtain
p.I'm happy to extend this PR with similiar smale-scale changes for other distributions.