Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing 'none' keyword when applying to source list #156

Merged

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Nov 9, 2020

The bug was uncovered in #152 but also affects other parts as shown in the added test.

@jelhan jelhan added the bug label Nov 9, 2020
@jelhan
Copy link
Collaborator Author

jelhan commented Nov 9, 2020

Ember CLI beta scenario is failing. This was already the case in #154, which refactored the testing suite. So it doesn't seem to be related to this change.

@jelhan jelhan merged commit 8c4067a into master Nov 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the append-source-list-util-removes-existing-none-keyword branch November 9, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant