Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write heuristics to output file #98

Closed
wants to merge 2 commits into from
Closed

Conversation

elig0n
Copy link
Contributor

@elig0n elig0n commented Dec 12, 2020

This appends 'heuristics' dict to the saved JSON

This appends 'heuristics' dict to the saved JSON
@s0md3v
Copy link
Owner

s0md3v commented Dec 12, 2020

Hey @elig0n, thanks for the bug fixes, I merged them all.

However, the parameters found by heuristics aren't intended to be save to the output. Arjun verifies those parameters and includes them them in params object in the JSON output. The only thing that should be fixed here is that the initialize function shouldn't return the found variable.

I am closing this for now but open for discussion.

@s0md3v s0md3v closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants