Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys for dependencies of Dropwizard #480

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Dec 28, 2021

These are the keys (or lack thereof) for the current dependencies of the
Dropwizard project.

I haven't verified their authenticity. Caveat emptor.

@rhowe
Copy link
Contributor Author

rhowe commented Dec 28, 2021

FYI @joschi & @jplock

mvn -Dpgpverify.keysMapLocation=https://raw.github.com/rhowe/pgp-keys-map/add-more/resources/pgp-keys-map.list org.simplify4u.plugins:pgpverify-maven-plugin:check

runs clean on the dropwizard repo for me

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thanks for this PR.

Please also add some examples of artifacts to test pom, when version will be upgraded we have sure that keys is still correct.

You can add to pgp-keys-map-test1/pom.xml or create separate module if you wish add more dropwizard artifacts.

resources/pgp-keys-map.list Outdated Show resolved Hide resolved
resources/pgp-keys-map.list Outdated Show resolved Hide resolved
resources/pgp-keys-map.list Outdated Show resolved Hide resolved
resources/pgp-keys-map.list Outdated Show resolved Hide resolved
resources/pgp-keys-map.list Outdated Show resolved Hide resolved
@rhowe
Copy link
Contributor Author

rhowe commented Dec 28, 2021

Very thanks for this PR.

Please also add some examples of artifacts to test pom, when version will be upgraded we have sure that keys is still correct.

You can add to pgp-keys-map-test1/pom.xml or create separate module if you wish add more dropwizard artifacts.

Thanks. I've added entries for everything, except the google protobuf key is for an older version of the lib than is in the test pom, so I left that version as-is.

What about the org.glassfish.jersey.... ones? Should I change that to be org.glassfish.jersey.*?

@slawekjaranowski
Copy link
Member

@rhowe please fix build ...

@slawekjaranowski
Copy link
Member

You can use org.glassfish.jersey.* the same key is used.

I don't see any dependency for io.dropwizard...

Maybe we can use also io.dropwizard.* for keys

@rhowe rhowe force-pushed the add-more branch 2 times, most recently from a2165d8 to 49870bb Compare December 28, 2021 21:40
These are the keys (or lack thereof) for the current dependencies of the
Dropwizard project.

I haven't verified their authenticity. Caveat emptor.
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Dec 29, 2021
@slawekjaranowski slawekjaranowski merged commit 2f89516 into s4u:master Dec 29, 2021
@rhowe rhowe deleted the add-more branch December 29, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Development

Successfully merging this pull request may close these issues.

2 participants