Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antlr4-runtime from 4.9.3 to 4.10 in /pgp-keys-map-test1 #644

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 12, 2022

Bumps antlr4-runtime from 4.9.3 to 4.10.

Release notes

Sourced from antlr4-runtime's releases.

4.10 Major feature, code clean up, and bug fix release

ANTLR version 4.10

This is a very major release with a number of important changes. There have been many valuable contributions, but I welcome @​KvanTTT and @​jcking as recent "official" major ANTLR contributors. :)

WARNING: Generated 4.10 lexers and parsers are incompatible with code generated by previous versions of ANTLR. You must regenerate all of your code from grammars to use the new runtime. This is true of all targets (except probably javascript).

Repo branching structure

We have changed the branching structure of the repository. The default branch for this repo remains master and it is the latest stable release with tags for the various releases; e.g., see release tag 4.9.3. We now do development work in branch dev between releases and all pull requests should be derived from that branch. The dev branch is merged back into master to cut a release and the release state is tagged (e.g., with 4.10-rc.1 or 4.10.) Visually our process looks roughly like this:

Targets such as Go that pull directly from the repository can use the default master branch but can also pull from the active dev branch:

$ go get github.com/antlr/antlr4/runtime/Go/antlr@dev

Developers certificate of origin

In order to bring ANTLR more in line with current standard standards for contribution processes, as of 4.10, ANTLR uses the Linux Foundation's Developer Certificate of Origin, DCO, version 1.1. See file https://github.com/antlr/antlr4/raw/master/developer-cert-of-origin.txt . It is simpler than the original contributors license agreement, which required programmers to sign the contributors.txt file, which has now moved to file historical-contributors-agreement.txt .

Each commit in pull requests must have a "signature", which is simple as using -s (not -S) on the git commit command:

$ git commit -s -m 'This is my commit message'

Github's pull request process enforces the sig and gives instructions on how to fix any commits that lack the sig. See https://github.com/apps/dco for more info.

4.10-generated parsers incompatible with previous runtimes

ANTLR not only generates recursive-descent parsers; it generates a state machine called an augmented transition network (ATN) in serialized form as a bunch of integers stored in the generated parser and lexer files. This serialization format was changed for 4.10 to remove a size limit on the supported ATNs. See antlr/antlr4#3591.

The key point here is that we changed the version number stored inside the serialization format and so, in order to use this new version of ANTLR, you must regenerate all of your lexers and parsers using the 4.10 tool and then use the new runtime. Parsers generated with 4.10 or not compatible with previous versions of the runtime.

Increasing minimum java version

Going forward, we are using Java 11 for the source code and the compiled .class files for the ANTLR tool. The Java runtime target, however, and the associated runtime tests use Java 8 (bumping up from Java 7).

JavaScript target

The JS target has been substantially reworked.

Miscellaneous improvements

  • Lexer rules can use the caseInsensitive option now.
  • Improved error messages
  • We rebuilt the runtime testing rig and made continuous integration improvements; part of this was done to support more recent versions of Java

... (truncated)

Commits
  • c7567ba [maven-release-plugin] prepare release 4.10
  • d11a10e tweak doc
  • e56dff6 Merge branch 'dev' of github.com:antlr/antlr4 into dev
  • 0d4f6c9 Merge branch 'master' of github.com:antlr/antlr4
  • 3e182e9 update script to have warning
  • ade6181 [C++] Update version to 4.10 (#3647)
  • 728c7cb Merge pull request #3646 from jcking/cpp-update-version
  • 74be2b6 [C++] Update version to 4.10
  • 4b90953 change c++ version file for script
  • 1684238 [C++] Fix bugs in ParserATNSimulator and PredictionContextMergeCache (#3644)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 12, 2022
@robot-simplify4u robot-simplify4u enabled auto-merge (rebase) April 12, 2022 01:11
@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

This build error will be resolved by merging PR #643 then rebasing this PR.

@slawekjaranowski
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch from e32c9cd to d6d3c06 Compare April 12, 2022 16:18
@slawekjaranowski
Copy link
Member

@ao-apps everybody can say @dependabot rebase

@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

@ao-apps everybody can say @dependabot rebase

Okay, thanks.

@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch from d6d3c06 to b12e074 Compare April 12, 2022 17:17
@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch from b12e074 to c3047b3 Compare April 12, 2022 17:28
@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

"Auto Approve" has error 'Error: Internal Server Error occurred while resolving "dependabot/fetch-metadata@v1.3.0"'

Maybe dependabot didn't like being rebased while a rebase is in progress?

@slawekjaranowski This PR should be OK to merge.

auto-merge was automatically disabled April 12, 2022 17:48

Pull request was closed

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 12, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch April 12, 2022 17:48
@slawekjaranowski slawekjaranowski restored the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch April 12, 2022 17:51
@ao-apps
Copy link
Contributor

ao-apps commented Apr 12, 2022

@slawekjaranowski Thank you.

@ao-apps
Copy link
Contributor

ao-apps commented Apr 14, 2022

@dependabot rebase

Bumps [antlr4-runtime](https://github.com/antlr/antlr4) from 4.9.3 to 4.10.
- [Release notes](https://github.com/antlr/antlr4/releases)
- [Changelog](https://github.com/antlr/antlr4/blob/master/CHANGES.txt)
- [Commits](antlr/antlr4@4.9.3...4.10)

---
updated-dependencies:
- dependency-name: org.antlr:antlr4-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch from c3047b3 to 78c6084 Compare April 14, 2022 04:03
@robot-simplify4u robot-simplify4u enabled auto-merge (rebase) April 14, 2022 04:03
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@robot-simplify4u robot-simplify4u merged commit 30b01b8 into master Apr 14, 2022
@robot-simplify4u robot-simplify4u deleted the dependabot/maven/pgp-keys-map-test1/org.antlr-antlr4-runtime-4.10 branch April 14, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

3 participants