Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple KeysMap files to be specified #263

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Allow multiple KeysMap files to be specified #263

merged 1 commit into from
Apr 8, 2021

Conversation

slawekjaranowski
Copy link
Member

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Apr 6, 2021
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Apr 6, 2021
View reviewed changes
@slawekjaranowski
Copy link
Member Author

fix for #246

pavelhoral
pavelhoral reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I might give it a look and I like it. Found just a few typos (sorry for nitpicking :))

src/site/markdown/keysmap-multiple.md.vm Outdated Show resolved Hide resolved
src/site/markdown/keysmap-multiple.md.vm Outdated Show resolved Hide resolved
src/site/markdown/keysmap-multiple.md.vm Outdated Show resolved Hide resolved
src/site/markdown/keysmap-multiple.md.vm Outdated Show resolved Hide resolved
src/site/markdown/keysmap-multiple.md.vm Outdated Show resolved Hide resolved
src/site/site.xml Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member Author

@pavelhoral thanks, I've fixed

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.0% 98.0% Coverage
0.0% 0.0% Duplication

@slawekjaranowski slawekjaranowski merged commit 3d1d6e5 into master Apr 8, 2021
@slawekjaranowski slawekjaranowski deleted the mulit-keysmap branch April 8, 2021 17:17
@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Apr 8, 2021
pzygielo pushed a commit to pzygielo/pgpverify-maven-plugin that referenced this pull request May 31, 2024
@cstamas
[MRESOLVER-339] Preemptive auth fix (s4u#263)
7c06f70 
Code is broken when default HTTP or HTTPS (80 or 443) ports are used, as SharedAuthCache "normalized" host will not match those of pre-set in case of preemptive auth. The UT case (non-default ports) works and is valid, as UT cannot bind ports 80 or 443.

Fix: expose AuthCache and do things "by the book".

---

https://issues.apache.org/jira/browse/MRESOLVER-339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelhoral pavelhoral pavelhoral left review comments

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @pavelhoral