Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --omit-implicit-checks to dart2js in release mode #473

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Pass --omit-implicit-checks to dart2js in release mode #473

merged 1 commit into from
Sep 11, 2018

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 11, 2018

Substantially addresses #113

@nex3 nex3 requested a review from jmesserly September 11, 2018 20:13
jmesserly
jmesserly approved these changes Sep 11, 2018
View reviewed changes
Copy link

@jmesserly jmesserly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nex3 nex3 merged commit 918a3fe into master Sep 11, 2018
@nex3 nex3 deleted the omit-implicit-checks branch September 11, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmesserly jmesserly jmesserly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @jmesserly