-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for freebsd #79
Conversation
5a253bb
to
5467c79
Compare
fyi, the failed travis jobs aren't from the puppet code; they're from a failure to install certain gems. |
hi -- just wanted to follow up on this. |
Can you please rebase your PR? I'll merge it asap then. |
@sethlyons Hmm, why this params is hard coded? 'value' => '"-m" "950" "-l" "0.0.0.0" "-p" "11211" "-U" "11211" "-u" "nobody" "-c" "8192" "-t" "1"', I've try to add FreeBSD support one year ago (see #73 ), but recently I was forced to fork ( https://forge.puppet.com/olevole/memcached/readme ), as I tired to waiting and my clients use FreeBSD a wide |
I'm sorry that I'm also limited with my free time. I'm trying to get things in as fast as possible, but sometimes, my priorities are on different things... Anyway, I'd like to merge this PR and maybe it's useful for you to get rid of your fork. And to answer your question: those params are hard-coded, because those are tests for the module. |
thanks for merging! possible to do a new release for forge? |
@sethlyons Can you give the current master a try if it's working as expected for you? |
@saz I certainly understand that the root of all evil - lake of spare time, we all suffer from this ;-) @sethlyons Unfortunately, your patch is not suitable for my use. How do you change the settings in FreeBSD if you do not create a configuration file to run? For example, with such a configuration as:
memcached launched via puppet in this form:
My version of pull/patch create configuration in /etc/rc.conf.d/memcached:
So i sure that memcached started in next time without puppet with corrected settings:
see my .erb: |
@olevole The missing config file is the reason, I've asked @sethlyons to give the current master a try. But I think, I'll grab this part from your PR to get this working as expected. And for anything else: Let's stop wasting our time and invest it, to improve this module for FreeBSD ;-) |
i made these changes. they're just about ready but still need some finishing touches. i'll open a new PR later tonight or tomorrow. |
No description provided.