Tail recursion from inside value defs

[LucySMartin]

Compiler version

3.4.1

Minimized code

import scala.annotation.tailrec
  @tailrec
  def foo(i: Int): Int = {
    if (i > 10000000) {
      i
    } else {
      val bar: String = {
        return foo(i + 1)
        "foo"
      }
      -1
    }
  }
println(foo(0))

Output

Stack overflow error on the line return foo(i + 1)

Expectation

10000001 should be prited to the console - or if it is determined this is not a tail location - it shoud fail to compile.

[LucySMartin]

Noticed this while resolving merge conflicts on #20143 its an easy fix.

[som-snytt]

I think there was a Scala 3 tweak to consider returns as tail pos? This errors on 2.13.

[LucySMartin]

Either wat it shouldn't stack overflow.
Either rewrite to a loop, or fail because it can't.
I'll fix this once we either merge or reject #20143. No need to create extra merge conflicts.