Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version on install instructions to 0.20.0 #413

Closed
wants to merge 1 commit into from

Conversation

fiatjaf
Copy link

@fiatjaf fiatjaf commented Feb 20, 2022

fixes #402

@sjrd
Copy link
Collaborator

sjrd commented Feb 21, 2022

I could merge this, but it would be overwritten by a bot on the next merge on main. The actual source for this is at

// For Scala.js 1.x
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "{{version}}")
// Or, for Scala.js 0.6.x
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler-sjs06" % "{{version}}")

We should probably replace the dynamic {{version}}s by hard-corded ones.

@fiatjaf
Copy link
Author

fiatjaf commented Feb 21, 2022

Why is the {{version}} printing the wrong value though? It would work if {{version}} corresponded to the latest release.

@sjrd
Copy link
Collaborator

sjrd commented Feb 21, 2022

I don't know. It's possible that the value of {{version}} comes from

version = ${version}

However, I don't know where the ${version} comes from. 🤷‍♂️

@fiatjaf
Copy link
Author

fiatjaf commented Feb 21, 2022

ahahah, well, apparently it is a built-in thing from ornate, and there seems to be also a ${tag} value.

I should try to rebuild the pages using that and send a proper PR, but I'm just trying to learn the basic of basics of Scala here and all these sbt things are imploding my head already so I'll refrain from doing it now :P

@fiatjaf fiatjaf closed this Feb 26, 2022
@fiatjaf fiatjaf deleted the patch-1 branch February 26, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants