FormatWriter: fix end marker handling #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current issue is that the span is computed using `leftLineId` of the token just before and the token at the end. However, `leftLineId` refers to the beginning of the token, thus multiline comments are incorrectly accounted. Instead, use the token at the beginning of the span and increase by 1.
|
@tgodzik thank you, happy holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue is that the span is computed using
leftLineIdof the token just before and the token at the end. However,leftLineIdrefers to the beginning of the token, thus multiline comments are incorrectly accounted.Instead, use the token at the beginning of the span and increase by 1. Fixes #3731.