feat(redis): require the node_type field in MigrateClusterRequest (#3704

)
scaleway · Mar 7, 2024 · 79c711d · 79c711d
1 parent b61f038
commit 79c711d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden b/cmd/scw/testdata/test-all-usage-redis-cluster-migrate-usage.golden
@@ -7,7 +7,7 @@ USAGE:
 
 ARGS:
   [version]         Redis™ engine version of the Database Instance
-  [node-type]       Type of node to use for the Database Instance
+  node-type         Type of node to use for the Database Instance
   [cluster-size]    Number of nodes for the Database Instance
   cluster-id        UUID of the Database Instance to update
   [zone=fr-par-1]   Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | pl-waw-1 | pl-waw-2)

diff --git a/docs/commands/redis.md b/docs/commands/redis.md
@@ -287,7 +287,7 @@ scw redis cluster migrate <cluster-id ...> [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | version |  | Redis™ engine version of the Database Instance |
-| node-type |  | Type of node to use for the Database Instance |
+| node-type | Required | Type of node to use for the Database Instance |
 | cluster-size |  | Number of nodes for the Database Instance |
 | cluster-id | Required | UUID of the Database Instance to update |
 | zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |

diff --git a/internal/namespaces/redis/v1/redis_cli.go b/internal/namespaces/redis/v1/redis_cli.go
@@ -421,7 +421,7 @@ func redisClusterMigrate() *core.Command {
 			{
 				Name:       "node-type",
 				Short:      `Type of node to use for the Database Instance`,
-				Required:   false,
+				Required:   true,
 				Deprecated: false,
 				Positional: false,
 			},