Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(baremetal): change offerid positional true getofferrequest #3667

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
Get details of an offer identified by its offer ID.

USAGE:
scw baremetal offer get [arg=value ...]
scw baremetal offer get <offer-id ...> [arg=value ...]

EXAMPLES:
Get a server offer with the ID
scw baremetal offer get zone=fr-par-1 offer-id=11111111-1111-1111-1111-111111111111
scw baremetal offer get 11111111-1111-1111-1111-111111111111 zone=fr-par-1

ARGS:
offer-id ID of the researched Offer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ARGS:
[nats-account-id] ID of the NATS account
[name] Name of the saved context, defaults to account name
[credentials-name] Name of the created credentials
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams)

FLAGS:
-h, --help help for create-context
Expand Down
4 changes: 2 additions & 2 deletions docs/commands/baremetal.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Get details of an offer identified by its offer ID.
**Usage:**

```
scw baremetal offer get [arg=value ...]
scw baremetal offer get <offer-id ...> [arg=value ...]
```


Expand All @@ -144,7 +144,7 @@ scw baremetal offer get [arg=value ...]

Get a server offer with the ID
```
scw baremetal offer get zone=fr-par-1 offer-id=11111111-1111-1111-1111-111111111111
scw baremetal offer get 11111111-1111-1111-1111-111111111111 zone=fr-par-1
```


Expand Down
2 changes: 1 addition & 1 deletion docs/commands/mnq.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ scw mnq nats create-context [arg=value ...]
| nats-account-id | | ID of the NATS account |
| name | | Name of the saved context, defaults to account name |
| credentials-name | | Name of the created credentials |
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams` | Region to target. If none is passed will use default region from the config |


**Examples:**
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/moby/buildkit v0.11.6
github.com/opencontainers/go-digest v1.0.0
github.com/pkg/errors v0.9.1
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240216140742-8458171690b9
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.24.0.20240220132654-d9816b542928
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.8.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240216140742-8458171690b9 h1:nOnOHw2FhA4zfwGi8yyCIinZtmRHkoxLH3Tyyd7RFAY=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.23.0.20240216140742-8458171690b9/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.24.0.20240220132654-d9816b542928 h1:E9j40l0wkkxGH5eRsCWm4PMK8deMx9MRxCWIBsjkXWk=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.24.0.20240220132654-d9816b542928/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/baremetal/v1/baremetal_cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ func baremetalOfferGet() *core.Command {
Short: `ID of the researched Offer`,
Required: true,
Deprecated: false,
Positional: false,
Positional: true,
},
core.ZoneArgSpec(scw.ZoneFrPar1, scw.ZoneFrPar2, scw.ZoneNlAms1, scw.ZoneNlAms2),
},
Expand Down
Loading