Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new scipp.bin and scipp.hist #164

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Use new scipp.bin and scipp.hist #164

merged 4 commits into from
Sep 2, 2024

Conversation

SimonHeybrock
Copy link
Member

No description provided.

jl-wynen
jl-wynen approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the old code. But I assume it only did optimisations that are now donw by bin/hist directly?

@SimonHeybrock SimonHeybrock marked this pull request as draft August 30, 2024 11:55
@SimonHeybrock
Copy link
Member Author

There appears to be an issue where scipp.hist drops a coord it should not drop in some case, need to investigate.

@SimonHeybrock SimonHeybrock marked this pull request as ready for review September 2, 2024 10:34
@SimonHeybrock SimonHeybrock merged commit 9ba6608 into main Sep 2, 2024
4 checks passed
@SimonHeybrock SimonHeybrock deleted the scipp-new-bin-hist-2 branch September 2, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen jl-wynen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonHeybrock @jl-wynen