Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying disk devices with deep symlink path breaks -r (-d is fine) #79

Closed
Korkman opened this issue Sep 19, 2024 · 2 comments
Closed

Comments

@Korkman
Copy link

Korkman commented Sep 19, 2024

SUMMARY

Specifying disk devices with deep symlink path breaks -r (-d is fine)

ISSUE TYPE
  • Bug Report
DOOL VERSION

1.3.2

OS / ENVIRONMENT

Ubuntu Noble, MX Linux, Debian

STEPS TO REPRODUCE
$ dool -r -D "/dev/disk/by-path/pci-0000:00:14.0-usb-0:6:1.0-scsi-0:0:0:0"
EXPECTED RESULTS

I/O stats

ACTUAL RESULTS
Traceback (most recent call last):
  File "/usr/local/bin/dool", line 2723, in main
    plug.prepare()
  File "/usr/local/bin/dool", line 506, in prepare
    raise Exception('No counter objects to monitor')
Exception: No counter objects to monitor

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/dool", line 3057, in <module>
    __main()
  File "/usr/local/bin/dool", line 3045, in __main
    main()
  File "/usr/local/bin/dool", line 2726, in main
    if mod == mods[-1]:
       ^^^
NameError: name 'mod' is not defined
@Korkman Korkman changed the title Full dev name breaks -r (but not -d) Specifying disk devices with deep symlink path breaks -r (-d is fine) Sep 19, 2024
@scottchiefbaker
Copy link
Owner

I think I figured this out in commit 8de8e35. Works on my local machine if I use:

dool --io -D /dev/disk/by-uuid/883e5732-db9f-41d4-8df2-809672f43b0e

Can you test and let me know?

@Korkman
Copy link
Author

Korkman commented Sep 19, 2024

Fix confirmed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants