NPM packages broken before v3.0.3 #1369
Assignees
Labels
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
type: CI
An issue with our continuous integration tests
Milestone
Comments
joeyparrish
added
type: bug
joeyparrish
added a commit
to joeyparrish/shaka-packager
that referenced
this issue
Mar 12, 2024
joeyparrish
pushed a commit
to joeyparrish/shaka-packager
that referenced
this issue
Mar 12, 2024
🤖 I have created a release *beep* *boop* --- ## [3.0.4](v3.0.3...v3.0.4) (2024-03-12) ### Bug Fixes * Fix docker action config to respect existing checkout/tags ([af341ed](af341ed)) * Fix NPM binary publication ([78fdbb4](78fdbb4)), closes [shaka-project#1369](https://github.com/joeyparrish/shaka-packager/issues/1369) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joeyparrish
added a commit
to joeyparrish/shaka-packager
that referenced
this issue
Mar 12, 2024
The default .npmignore would disallow bin/, which contains binaries for our NPM release. Every release before v3.0.3 was missing .npmignore, and therefore had no binaries. These were unusable in npm, and have been marked as deprecated because of it. Closes shaka-project#1369
joeyparrish
added a commit
to joeyparrish/shaka-packager
that referenced
this issue
Mar 12, 2024
The default .npmignore would disallow bin/, which contains binaries for our NPM release. Every release before v3.0.3 was missing .npmignore, and therefore had no binaries. These were unusable in NPM, and have been marked as deprecated because of it. Closes shaka-project#1369
joeyparrish
added a commit
that referenced
this issue
Mar 12, 2024
The default .npmignore would disallow bin/, which contains binaries for our NPM release. Every release before v3.0.3 was missing .npmignore, and therefore had no binaries. These were unusable in NPM, and have been marked as deprecated because of it. Closes #1369
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
All NPM releases before v3.0.3 (upcoming) are missing their binaries. The prepublish script downloads the binaries, but the default .npmignore file prevents those from being picked up in the archive. Because of this, we have never made a correct NPM release ever before.
For history, NPM packages were originally requested by @nampdn in 2018 in #290.
There are currently 0 projects referencing the
shaka-packagerpackages through npmjs, but there are ~100 downloads per week. Those could all be bots mirroring NPM, though. Hard to say.I will mark all existing releases in NPM as "deprecated", but I won't unpublish them. This should be fixed in v3.0.3.
The text was updated successfully, but these errors were encountered: