Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hls, set the DEFAULT explicitly to NO. Supports native HLS players. #1170

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

sarge
Copy link
Contributor

@sarge sarge commented Feb 1, 2023

It appears that not all Apple implementations follow the HLS guidelines.

While the DEFAULT=NO for an audio track should be optional and default to NO, in practice native HLS players Safari and iOS devices treat the missing DEFAULT as a MAYBE.

Fixes #1169

@joeyparrish joeyparrish merged commit 1ab6818 into shaka-project:main Jul 5, 2023
joeyparrish pushed a commit that referenced this pull request Jul 12, 2023
…1226)

Updating golden files for failing ttml tests in packager_test.py related
to #1179 and
failing HLS unit tests related to
#1170.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLS Set Default=NO
2 participants