Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tags in official Docker images and binaries #1370

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

joeyparrish
Copy link
Member

The release workflows did not run checkout with fetch-tags: true, so the builds were unable to compute the correct release version number. I audited all instances of actions/checkout to add fetch-tags where needed and clean up unneeded options.

I also had to fix options to docker/build-push-action, which by default ignores actions/checkout and tries to pull from git itself. This led to the Docker build running in a context without the new tag.

Finally, to make verification easier and provide version info in the build logs, this adds debugging info to the version-generation script via stderr.

Closes #1366

The release workflows did not run checkout with fetch-tags: true, so
the builds were unable to compute the correct release version number.
I audited all instanced of actions/checkout to add fetch-tags where
needed and clean up unneeded options.

Closes shaka-project#1366
@joeyparrish
Copy link
Member Author

See the fix at work here:

$ docker run joeyparrish/shaka-packager-staging:v3.0.4 packager --version
packager version v3.0.4-f52052a-debug

@joeyparrish joeyparrish merged commit d83c7b1 into shaka-project:main Mar 12, 2024
37 checks passed
@joeyparrish joeyparrish deleted the fix-docker-version branch March 12, 2024 20:09
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label May 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[minor] Fix the version number in the docker build
2 participants