Revive micro-benchmarks for vector functions #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the result of the function call during its benchmark to prevent it from being optimized away. Also changed name of NITER1 and NITER2 macros to more obvious acronymes. Tested on aarch64 and x86 so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Check if existent micro benchmark program is working.
The micro benchmark system in place would compile and run hitting no errors, however, the execution time returned for every function seemed flatlined at 2ns (as described in #445). Turns out the function call was being optimized away during its benchmark.
Updated program with relevant changes to prevent this.
What changes did you make?
Store the result of the function call during the benchmark, which prevents the compiler from removing the function call. Also added a warm up call.
Does this PR relate to any existing issue?
This PR should fix #445 and relates to issue #9.