NEXT-33884 - quickfixes for Meteor Admin SDK #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojanrajh
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
I'm approving this changes until we merge shopware/developer-portal#197 and shopware/meteor#53 (see preview). Then we'll also check for old links in our docs.
bojanrajh
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Actually, there's one thing to fix: https://github.com/shopware/developer-portal/actions/runs/8200236466/job/22426620596#step:7:27
sushmangupta
approved these changes
Mar 8, 2024
bojanrajh
approved these changes
Mar 11, 2024
Sounds good! @sushmangupta Thanks for fixing the text to matching the style guide 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation has outdated parts in terms of developing apps for administration. This PR isn't going to rewrite everything to use our recommended way of extending applications, the Meteor Admin SDK. Instead, it only contains some small quickfixes and wins. This is to make it clearer to the reader that the current articles are only suitable for extremely small applications.
It also contains some structure fixes, e.g. moving the CMS Element creation article to the correct apps directory instead of the plugins directory, adding a small article at the beginning of each article in the admin app series, etc.