Fix deadlock in parallel mode #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I tested this in Pr0methean/OcHd-RustBuild@7f2f5f3 (which was also using #524 and zopfli-rs/zopfli#21), I got a stack overflow on 64x64 images. |
|
Oh, I thought you said it was working? Or is just specific sizes that do/don't work? |
|
It seems to depend in a weird way on the version of the zopfli crate I'm using. |
|
I suspect it may not be an issue with oxipng. You may have to debug that one yourself. |
shssoichiro
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When oxipng is run within an existing rayon context, there may not be any spare threads to execute the evaluations, causing a deadlock. This change adds a yield loop so that the main thread can execute the evaluations when necessary.
Fixes #517