Merge pull request #29 from shunsambongi/hotfix/log-appender

Hotfix: logging

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: chex
 Title: Run Checks
-Version: 0.1.2
+Version: 0.1.3
 Authors@R: 
     person(given = "Shun",
            family = "Sambongi",
@@ -26,10 +26,11 @@ Suggests:
     logger,
     mockery,
     rmarkdown,
-    testthat
+    testthat,
+    withr
 VignetteBuilder: 
     knitr
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.1.0
+RoxygenNote: 7.1.1

NEWS.md

@@ -1,3 +1,7 @@
+# chex 0.1.3
+
+* Hotfix: fix package log_appender
+
 # chex 0.1.2
 
 * Bugfix: logging ignores formatting and uses result descriptions as-is.

R/logging.R

@@ -20,3 +20,19 @@ log_result <- function(result) {
   }
   invisible(result)
 }
+
+init_logging <- function() {
+  if (!requireNamespace("logger", quietly = TRUE)) {
+    return(invisible())
+  }
+
+  try(silent = TRUE, {
+    namespaces <- get(
+      "namespaces", envir = asNamespace("logger"), mode = "environment"
+    )
+    if (!exists("chex", namespaces)) {
+      logger::log_appender(identity, namespace = "chex")
+    }
+  })
+  invisible()
+}

R/zzz.R

@@ -1,5 +1,4 @@
 .onLoad <- function(...) {
-  logger::log_appender(identity, namespace = "chex")
+  init_logging()
   vctrs::s3_register("dplyr::filter", "chex_result")
 }
-

tests/testthat/test-result.R

@@ -86,7 +86,7 @@ test_that("equality works", {
 test_that("aggregation works", {
   len <- 20
   every <- result(rep(TRUE, len), NA)
-  some <- vec_assign(every, (1:len) <= 10, result(FALSE, NA))
+  some <- result(c(rep(TRUE, len / 2), rep(FALSE, len / 2)), NA)
   expect_length(every, len)
   expect_length(some, len)
   expect_true(any(every))

tests/testthat/test-status.R

@@ -60,7 +60,7 @@ test_that("equality work", {
 test_that("aggregation works", {
   n <- 20
   every <- status_(rep("PASS", n))
-  some <- vec_assign(every, (1:n) <= 10, FALSE)
+  some <- status_(c(rep("PASS", n / 2), rep("FAIL", n / 2)))
   expect_length(every, n)
   expect_length(some, n)
 

vignettes/logging.Rmd

@@ -1,5 +1,10 @@
 ---
 title: "Logging"
+output: rmarkdown::html_vignette
+vignette: >
+  %\VignetteIndexEntry{Logging}
+  %\VignetteEngine{knitr::rmarkdown}
+  %\VignetteEncoding{UTF-8}
 ---
 
 ```{r, include = FALSE}