Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Feat: siren faq update #4685

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Feat: siren faq update #4685

wants to merge 7 commits into from

Conversation

rickimoore
Copy link
Member

Issue Addressed

Siren FAQ requires more information regarding network connections to lighthouse BN/VC

Proposed Changes

Added more info regarding port, BN/VC flags, ssh tunneling and VPNs access

jimmygchen
jimmygchen reviewed Aug 31, 2023
View reviewed changes
book/src/ui-faqs.md Outdated Show resolved Hide resolved
@jimmygchen
Copy link
Member

Nice! I think it's definitely a bit easier to read now after moving SSH tunnel requirement & instructions to FAQ.
I've added some small comments but I think it would be helpful if @chong-he takes a second look? (I think he wrote /update the ssh tunnel sections recently) 🙏

@chong-he
Copy link
Member

Nice! I think it's definitely a bit easier to read now after moving SSH tunnel requirement & instructions to FAQ. I've added some small comments but I think it would be helpful if @chong-he takes a second look? (I think he wrote /update the ssh tunnel sections recently) 🙏

Thanks for the tag, left some comments as above

@chong-he chong-he added ready-for-review The code is ready for review docs Documentation labels Aug 31, 2023
AgeManning
AgeManning reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions. Looks good tho

book/src/ui-faqs.md Outdated Show resolved Hide resolved
book/src/ui-faqs.md Outdated Show resolved Hide resolved
book/src/ui-faqs.md Outdated Show resolved Hide resolved
book/src/ui-faqs.md Outdated Show resolved Hide resolved
rickimoore and others added 4 commits August 31, 2023 11:36
@rickimoore @AgeManning
Update book/src/ui-faqs.md
6cbf17c 
Co-authored-by: Age Manning <Age@AgeManning.com>
@rickimoore @AgeManning
Update book/src/ui-faqs.md
1e3c27b 
Co-authored-by: Age Manning <Age@AgeManning.com>
@rickimoore @AgeManning
Update book/src/ui-faqs.md
634a8ba 
Co-authored-by: Age Manning <Age@AgeManning.com>
@rickimoore
fix: made updates to faq based on code review
16767b7
jimmygchen
jimmygchen approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Thanks

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 31, 2023
@chong-he
Copy link
Member

Can we revise the link:
(./ui-faqs.html#5-how-do-i-connect-siren-to-lighthouse-via-a-ssh-tunnel)
to
(./ui-faqs.md#5-how-do-i-connect-siren-to-lighthouse-via-a-ssh-tunnel)
?

The .html one will have link error if clicked.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Aug 31, 2023
jimmygchen
jimmygchen approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jimmygchen jimmygchen added do-not-merge ready-for-merge This PR is ready to merge. v4.5.0 ETA Q4 2023 and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 31, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 6, 2023
@rickimoore
Feat: siren faq update (#4685)
0caf2af 
## Issue Addressed

Siren FAQ requires more information regarding network connections to lighthouse BN/VC

## Proposed Changes

Added more info regarding port, BN/VC flags, ssh tunneling and VPNs access
@bors
Copy link

bors bot commented Sep 6, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Feat: siren faq update [Merged by Bors] - Feat: siren faq update Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@rickimoore @Woodpile37
Feat: siren faq update (sigp#4685)
fe6e73b 
## Issue Addressed

Siren FAQ requires more information regarding network connections to lighthouse BN/VC

## Proposed Changes

Added more info regarding port, BN/VC flags, ssh tunneling and VPNs access
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@rickimoore @Woodpile37
Feat: siren faq update (sigp#4685)
9f50902 
## Issue Addressed

Siren FAQ requires more information regarding network connections to lighthouse BN/VC

## Proposed Changes

Added more info regarding port, BN/VC flags, ssh tunneling and VPNs access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@AgeManning AgeManning AgeManning approved these changes

@chong-he chong-he Awaiting requested review from chong-he

Assignees
No one assigned
Labels
docs Documentation ready-for-merge This PR is ready to merge. v4.5.0 ETA Q4 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickimoore @jimmygchen @chong-he @michaelsproul @AgeManning