Output network-test logs into files in CI #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackintosh
changed the title
ackintosh
added
ready-for-review
jimmygchen
approved these changes
Oct 3, 2024
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a4a673b |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#6322 (comment)
We need the logs when debugging network test errors in CI. However, there's a problem of log interleaving if we run tests concurrently.
Proposed Changes
Added
ci_loggerfeature flag, which enables outputting logs to files for each test. Also added anUpload logsstep to thenetwork-testsjob, where the log files are uploaded as GitHub Artifacts.The uploaded log files (Artifacts) can be downloaded from Summary page of the CI run.