Resolve some PeerDAS todos #6434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
dapplion
commented
Sep 25, 2024
Comment on lines
-1078
to
-1119
| // TODO(das): How is a consumer of sampling results? | ||
| // - Fork-choice for trailing DA | ||
| // - Single lookups to complete import requirements | ||
| // - Range sync to complete import requirements? Can sampling for syncing lag behind and | ||
| // accumulate in fork-choice? | ||
|
|
||
| match requester { | ||
| SamplingRequester::ImportedBlock(block_root) => { | ||
| debug!(self.log, "Sampling result"; "block_root" => %block_root, "result" => ?result); | ||
|
|
||
| // TODO(das): Consider moving SamplingResult to the beacon_chain crate and import | ||
| // here. No need to add too much enum variants, just whatever the beacon_chain or | ||
| // fork-choice needs to make a decision. Currently the fork-choice only needs to | ||
| // be notified of successful samplings, i.e. sampling failures don't trigger pruning |
There was a problem hiding this comment.
unnecessary comments
dapplion
commented
Sep 25, 2024
| @@ -802,7 +801,6 @@ impl<T: BeaconChainTypes> SyncNetworkContext<T> { | |||
| self.custody_by_root_requests.insert(requester, request); | |||
| Ok(LookupRequestResult::RequestSent(req_id)) | |||
| } | |||
| // TODO(das): handle this error properly | |||
There was a problem hiding this comment.
This refers to the fact that custody request errors are "nested" but it's okay. So far they are okay to debug
dapplion
commented
Sep 25, 2024
| @@ -22,7 +22,6 @@ pub type SamplingResult = Result<(), SamplingError>; | |||
| type DataColumnSidecarList<E> = Vec<Arc<DataColumnSidecar<E>>>; | |||
|
|
|||
| pub struct Sampling<T: BeaconChainTypes> { | |||
| // TODO(das): stalled sampling request are never cleaned up | |||
There was a problem hiding this comment.
Request can't go stale
dapplion
force-pushed
the
resolve-sampling-todos
branch
from
cd71575
to
55e8f5a
Compare
dapplion
force-pushed
the
resolve-sampling-todos
branch
from
55e8f5a
to
f6832de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Clean-up some stale
TODO(das)tagsProposed Changes
Explained inlined in code