-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lockbud task to CI #6470
base: unstable
Are you sure you want to change the base?
Add lockbud task to CI #6470
Conversation
We're getting a hit on a potential double lock here
It seems to be a false positive as these are read locks |
Oh nice catch! i think this could potentially deadlock because we try to acquire a 2nd lock on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have lockbud on CI :)
Issue Addressed
Closes #6413
Proposed Changes
Add lockbud to CI
Additional Info
Lockbud was pinned to 2024-05-20 Rust nightly. This conflicted with lazy_lock as it used to be an unstable feature. I've opened a PR here to pin it to the current latest Rust nightly (2024-10-05). I'm not sure if my changes have introduced any regressions, hopefully the author will review it soon and give some feedback.
BurtonQin/lockbud#70
Currently the new CI step uses a docker image hosted on my account
Steps to generate the docker image:
docker-instance
branchdocker build --platform linux/amd64 -t [namespace]/[repository] -f Dockerfile .