Add exit_hook configuration option #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silkeh
requested changes
Jun 11, 2017
pdns_api.sh
Outdated
|
|
||
| if [[ ! -z "${PDNS_EXIT_HOOK:-}" ]]; then | ||
| if [[ -x "${PDNS_EXIT_HOOK}" ]]; then | ||
| exec ${PDNS_EXIT_HOOK} |
There was a problem hiding this comment.
^-- SC2086: Double quote to prevent globbing and word splitting.
pdns_api.sh
Outdated
| # Interface for exit_hook | ||
| if [[ "${hook}" = "exit_hook" ]]; then | ||
| shift | ||
| exit_hook $@ |
There was a problem hiding this comment.
^-- SC2068: Double quote array expansions to avoid re-splitting elements.
pdns_api.sh
Outdated
| @@ -295,6 +295,19 @@ soa_edit() { | |||
| fi | |||
| } | |||
|
|
|||
| exit_hook() { | |||
|
|
|||
There was a problem hiding this comment.
Please remove the white space at the begin/end of the function.
silkeh
reviewed
Jun 11, 2017
pdns_api.sh
Outdated
| if [[ -x "${PDNS_EXIT_HOOK}" ]]; then | ||
| exec ${PDNS_EXIT_HOOK} | ||
| else | ||
| error "Your ${PDNS_EXIT_HOOK} not an executable" |
There was a problem hiding this comment.
Maybe change this to: error "${PDNS_EXIT_HOOK} is not an executable"
|
Thanks! I have added some (very minor) comments to take a look at. |
|
The suggestions implemented |
silkeh
approved these changes
Jun 12, 2017
|
Merged! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple addition to run a secondary script to distribute the new certificate files or restarts the configured services