Added dwarfFortress spinner
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
commented
Apr 2, 2023
| @@ -40,6 +40,7 @@ | |||
| "json" | |||
| ], | |||
| "devDependencies": { | |||
| "@types/node": "^17.0.41", | |||
There was a problem hiding this comment.
Re: this change, it looks like there was a breaking change to this package - see this stackoverflow post. Happy to adopt another approach if you want.
Also - happy to uprev the min version to node 8 if you're so inclined for deprecation/unit test reasons, but didn't want to do it unilaterally.
sindresorhus
reviewed
Apr 4, 2023
spinners.json
Outdated
| @@ -1464,5 +1464,143 @@ | |||
| "▰▰▰▰▰▰▰", | |||
| "▰▱▱▱▱▱▱" | |||
| ] | |||
| }, | |||
| "dwarfFortress": { | |||
| "interval": 100, | |||
There was a problem hiding this comment.
The animation feels a bit slow. 80 seems a bit smoother.
There was a problem hiding this comment.
yep, makes sense.
|
This is a fun one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extremely silly spinner for when you've progressed too far and unleashed something extremely Fun. Based off of Dwarf Fortress's ASCII tileset.