Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CustomBlockEmbed and customElementsEmbedBuilder #877

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

LucazzP
Copy link
Contributor

@LucazzP LucazzP commented Jul 21, 2022

Feature

Add the possibility to the developer to add custom blocks to the texts, so he will be able to use custom widgets inside the text. I added on example a possible custom block to add notes inside the text, but it can be anything.
I have a video with the example running with some notes added, to show that it works exactly as any other block, like the image or video.

Motivations

The client of the app that I am developing requested some extra functionalities to the text editor, like the Notion does add tables and everything else that is not only text and images...

How I made this

So to be able to add this feature, I needed to add this CustomBlockEmbed to create the data of the widget, and the customElementsEmbedBuilder to show the widget that I want with each type of Custom Block that I created.

Example

Screen.Recording.2022-07-20.at.23.30.26.mov

@singerdmx
Copy link
Owner

Looks good!
Could you update README as well ?

@singerdmx
Copy link
Owner

Also if you are adding new features like tables, please merge it here instead of CustomBlockEmbed so that it can be used by others. Thanks!

@LucazzP
Copy link
Contributor Author

LucazzP commented Jul 21, 2022

Looks good! Could you update README as well ?

Yes! I will update as soon as I can.

Also if you are adding new features like tables, please merge it here instead of CustomBlockEmbed so that it can be used by others. Thanks!

Of course! For now, he only wants custom widgets for the use of the app, tables is something that was not on our roadmap, but is a great idea to add haha, so when I add this, I will add here too.

@singerdmx
Copy link
Owner

Looks good! Could you update README as well ?

Yes! I will update as soon as I can.

Also if you are adding new features like tables, please merge it here instead of CustomBlockEmbed so that it can be used by others. Thanks!

Of course! For now, he only wants custom widgets for the use of the app, tables is something that was not on our roadmap, but is a great idea to add haha, so when I add this, I will add here too.

Thanks!

@singerdmx singerdmx merged commit 48f8932 into singerdmx:master Jul 21, 2022
@singerdmx
Copy link
Owner

Merging it now.
You can update readme in another PR.
Thanks

@dev-zayn
Copy link

please add an option to disable image/video icons?

@debmittarv
Copy link

Is there any option to customize the delete functionality of image. I am using embededBuilder for custom ui . I am able to add image , but I am not able to delete the particular image from editor. please help me....
Thank you in advance.

@dawarepramod4
Copy link

How to add the Button for this custom Builder in ToolBar..
please let us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants